Issue Details (XML | Word | Printable)

Key: MBS-2436
Type: Bug Bug
Status: Reopened Reopened
Priority: Normal Normal
Assignee: Unassigned
Reporter: Aurélien Mino
Votes: 2
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

"Edit medium" edits don't link to new recordings

Created: 31/May/11 12:33 PM   Updated: 24/Jan/13 06:57 AM
Component/s: Data display, Edit system
Affects Version/s: None
Fix Version/s: None

Issue Links:
Duplicate
 
Relates
 


 Description  « Hide

See e.g. http://musicbrainz.org/edit/14545825 first track.

I'm pretty sure there's another ticket but I could not find it.



Sort Order: Ascending order - Click to sort in descending order
Oliver Charles added a comment - 14/Sep/11 03:50 PM

Should we try to fix existing edits too? This could be tricky as we don't have the recording ID of the created recording anywhere. We could find all recordings with no edit in their history that is: add standalone, add track, edit medium and see if the recording is in use. If so, we someone how try and determine which release it came from?


voiceinsideyou added a comment - 14/Sep/11 04:29 PM

It'd certainly be nice if we could fix them but it sounds pretty tough; and maybe not worth our while getting such a fuzzy match right?

You'd be pretty much relying on a matching title right? Can you even be sure which artist the "new recording" is/was under; unless you assume that the current release's state represents the "new recording" that was being changed in the earlier edits?


Oliver Charles added a comment - 15/Sep/11 10:53 AM

Yea, it'll be difficult, because add medium actually also has this problem...


Aurélien Mino added a comment - 21/Sep/11 01:19 PM

It would be nice if the UI could show that new recordings have created with this edit.
Maybe by appending "(new)" next to the recording: "Recording title (new)"

This is an important information when evaluating a new release that is added.

Re try fixing existing edits, that would be nice, yes.
As a general note, I'm noticing that we store really too few information in edit data, and this is generating a lot of issues...


Oliver Charles added a comment - 21/Sep/11 02:38 PM

As a general note, I'm noticing that we store really too few information in edit data, and this is generating a lot of issues...

Sadly this has always been the case, and I don't know what to do about it. If we try and change it now we have to introduce a new version to most edits and the code gets horribly complicated. We can't upgrade most edits to add missing data though, because we don't have a view of the data at that point in time. http://acidcycles.wordpress.com/2011/07/28/versioning-multiple-versions-of-data-in-relational-databases/ is me trying to explain how I want to do things in BookBrainz (which is a combination of a Git model and a star schema, I think), but I don't know how well it will really scale. If anyone has ideas on how we can get out of this problem I'd love to talk about and invest some time in working on ideas too...


Oliver Charles added a comment - 24/Nov/11 12:59 PM

The review actually fixed something entirely different: http://codereview.musicbrainz.org/r/1530/


Ian McEwen added a comment - 12/Sep/12 06:39 AM

What's the status of this ticket? Based on the MBS-5241 work I think it should be possible to fix this completely, but I'd like to know what's been done and hasn't already.


Ian McEwen added a comment - 24/Jan/13 06:57 AM

Part of my changes for MBS-3514 will at least mark these as "this recording will be added when the edit applies" – i.e., they're marked as new. They do appear to show up in edit histories for the recording at least, which looks like what Oliver's changes were.

Is this sufficient?