Issue Details (XML | Word | Printable)

Key: MBS-5650
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: Calvin Walton
Votes: 1
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

ISE when attempting to approve already-closed release group edit

Created: 06/Dec/12 09:17 PM   Updated: 11/Feb/13 11:40 AM   Resolved: 11/Feb/13 11:40 AM
Component/s: Edit system
Affects Version/s: 2012-11-27
Fix Version/s: 2013-02-11


 Description  « Hide

I got this ISE:

Caught exception in MusicBrainz::Server::Controller::Edit->approve "The edit is not open anymore. at lib/MusicBrainz/Server/Data/Edit.pm line 583.
	MusicBrainz::Server::Data::Edit::accept('MusicBrainz::Server::Data::Edit=HASH(0xc1da910)', 'MusicBrainz::Server::Edit::ReleaseGroup::Edit=HASH(0x108f3e78)') called at lib/MusicBrainz/Server/Data/Edit.pm line 510
	MusicBrainz::Server::Data::Edit::__ANON__() called at lib/Sql.pm line 281
	Sql::__ANON__() called at local/lib/perl5/Try/Tiny.pm line 76
	eval {...} called at local/lib/perl5/Try/Tiny.pm line 67
	Try::Tiny::try('CODE(0xe18eed0)', 'Try::Tiny::Catch=REF(0x108f39b0)') called at lib/Sql.pm line 294
	Sql::_auto_transaction('CODE(0xe2682c8)', 'Sql=HASH(0xdc66b20)') called at lib/Sql.pm line 299
	Sql::_run_in_transaction_one('CODE(0xe2682c8)', 'Sql=HASH(0xdc66b20)') called at lib/Sql.pm line 313
	Sql::run_in_transaction('CODE(0xe2682c8)', 'Sql=HASH(0xdc66b20)') called at lib/MusicBrainz/Server/Data/Edit.pm line 511
	MusicBrainz::Server::Data::Edit::approve('MusicBrainz::Server::Data::Edit=HASH(0xc1da910)', 'MusicBrainz::Server::Edit::ReleaseGroup::Edit=HASH(0xa8f3648)', 53217) called at lib/MusicBrainz/Server/Controller/Edit.pm line 112
	MusicBrainz::Server::Controller::Edit::approve('MusicBrainz::Server::Controller::Edit=HASH(0xd2f5470)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst/Action.pm line 65
	Catalyst::Action::execute('Catalyst::Action=HASH(0xd65b480)', 'MusicBrainz::Server::Controller::Edit=HASH(0xd2f5470)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst.pm line 1672
	eval {...} called at local/lib/perl5/Catalyst.pm line 1672
	Catalyst::execute('MusicBrainz::Server=HASH(0xdbcda90)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xd65b480)') called at local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
	Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xdbcda90)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xd65b480)') called at lib/MusicBrainz/Server.pm line 311
	MusicBrainz::Server::execute('MusicBrainz::Server=HASH(0xdbcda90)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xd65b480)') called at local/lib/perl5/Catalyst/Action.pm line 60
	Catalyst::Action::dispatch('Catalyst::Action=HASH(0xd65b480)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst/ActionChain.pm line 38
	Catalyst::ActionChain::dispatch('Catalyst::ActionChain=HASH(0xdbc8ef8)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst/Controller.pm line 158
	Catalyst::Controller::_ACTION('MusicBrainz::Server::Controller::Edit=HASH(0xd2f5470)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst/Action.pm line 65
	Catalyst::Action::execute('Catalyst::Action=HASH(0xd65b780)', 'MusicBrainz::Server::Controller::Edit=HASH(0xd2f5470)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst.pm line 1672
	eval {...} called at local/lib/perl5/Catalyst.pm line 1672
	Catalyst::execute('MusicBrainz::Server=HASH(0xdbcda90)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xd65b780)') called at local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
	Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xdbcda90)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xd65b780)') called at lib/MusicBrainz/Server.pm line 311
	MusicBrainz::Server::execute('MusicBrainz::Server=HASH(0xdbcda90)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xd65b780)') called at local/lib/perl5/Catalyst/Action.pm line 60
	Catalyst::Action::dispatch('Catalyst::Action=HASH(0xd65b780)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst/Dispatcher.pm line 257
	Catalyst::Dispatcher::_do_forward('Catalyst::Dispatcher=HASH(0x519dc48)', 'forward', 'MusicBrainz::Server=HASH(0xdbcda90)', '_ACTION') called at local/lib/perl5/Catalyst/Dispatcher.pm line 237
	Catalyst::Dispatcher::forward('Catalyst::Dispatcher=HASH(0x519dc48)', 'MusicBrainz::Server=HASH(0xdbcda90)', '_ACTION') called at local/lib/perl5/Catalyst.pm line 362
	Catalyst::forward('MusicBrainz::Server=HASH(0xdbcda90)', '_ACTION') called at local/lib/perl5/Catalyst/Controller.pm line 132
	Catalyst::Controller::_DISPATCH('MusicBrainz::Server::Controller::Edit=HASH(0xd2f5470)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst/Action.pm line 65
	Catalyst::Action::execute('Catalyst::Action=HASH(0xd65ae80)', 'MusicBrainz::Server::Controller::Edit=HASH(0xd2f5470)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst.pm line 1672
	eval {...} called at local/lib/perl5/Catalyst.pm line 1672
	Catalyst::execute('MusicBrainz::Server=HASH(0xdbcda90)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xd65ae80)') called at local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
	Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xdbcda90)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xd65ae80)') called at lib/MusicBrainz/Server.pm line 311
	MusicBrainz::Server::execute('MusicBrainz::Server=HASH(0xdbcda90)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xd65ae80)') called at local/lib/perl5/Catalyst/Action.pm line 60
	Catalyst::Action::dispatch('Catalyst::Action=HASH(0xd65ae80)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst/Dispatcher.pm line 257
	Catalyst::Dispatcher::_do_forward('Catalyst::Dispatcher=HASH(0x519dc48)', 'forward', 'MusicBrainz::Server=HASH(0xdbcda90)', '/edit/_DISPATCH') called at local/lib/perl5/Catalyst/Dispatcher.pm line 237
	Catalyst::Dispatcher::forward('Catalyst::Dispatcher=HASH(0x519dc48)', 'MusicBrainz::Server=HASH(0xdbcda90)', '/edit/_DISPATCH') called at local/lib/perl5/Catalyst.pm line 362
	Catalyst::forward('MusicBrainz::Server=HASH(0xdbcda90)', '/edit/_DISPATCH') called at local/lib/perl5/Catalyst/Dispatcher.pm line 105
	Catalyst::Dispatcher::dispatch('Catalyst::Dispatcher=HASH(0x519dc48)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst.pm line 1618
	Catalyst::dispatch('MusicBrainz::Server=HASH(0xdbcda90)') called at lib/MusicBrainz/Server.pm line 270
	MusicBrainz::Server::__ANON__('MusicBrainz::Server=HASH(0xdbcda90)', 'CODE(0x44088f8)') called at lib/MusicBrainz/Server.pm line 366
	MusicBrainz::Server::with_translations('MusicBrainz::Server=HASH(0xdbcda90)', 'CODE(0x4a5c9d0)', 'CODE(0x44088f8)') called at lib/MusicBrainz/Server.pm line 277
	Class::MOP::Class:::around('CODE(0x44088f8)', 'MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
	Class::MOP::Method::Wrapped::__ANON__('MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 91
	MusicBrainz::Server::dispatch('MusicBrainz::Server=HASH(0xdbcda90)') called at local/lib/perl5/Catalyst.pm line 1968
	Catalyst::__ANON__() called at local/lib/perl5/Try/Tiny.pm line 76
	eval {...} called at local/lib/perl5/Try/Tiny.pm line 67
	Try::Tiny::try('CODE(0xd981ce8)', 'Try::Tiny::Catch=REF(0xdd470f8)') called at local/lib/perl5/Catalyst.pm line 1974
	Catalyst::handle_request('MusicBrainz::Server', 'env', 'HASH(0xdd63ca0)', 'response_cb', 'CODE(0xd933888)') called at local/lib/perl5/Catalyst/Plugin/AutoRestart.pm line 117
	Catalyst::Plugin::AutoRestart::handle_request('MusicBrainz::Server', 'env', 'HASH(0xdd63ca0)', 'response_cb', 'CODE(0xd933888)') called at local/lib/perl5/Catalyst/Engine.pm line 688
	Catalyst::Engine::__ANON__('CODE(0xd933888)') called at local/lib/perl5/Plack/Handler/FCGI.pm line 130
	Plack::Handler::FCGI::run('Plack::Handler::FCGI=HASH(0x27419d0)', 'CODE(0x4992c68)') called at local/lib/perl5/Plack/Loader.pm line 84
	Plack::Loader::run('Plack::Loader=HASH(0x2668c90)', 'Plack::Handler::FCGI=HASH(0x27419d0)') called at local/lib/perl5/Plack/Runner.pm line 267
	Plack::Runner::run('Plack::Runner=HASH(0x24f1808)') called at local/bin/plackup line 10
 at lib/Sql.pm line 294."

Stack trace:

    line 511 MusicBrainz::Server::Data::Edit
    line 112 MusicBrainz::Server::Controller::Edit
    line 311 MusicBrainz::Server
    line 311 MusicBrainz::Server
    line 311 MusicBrainz::Server
    line 270 MusicBrainz::Server
    line 366 MusicBrainz::Server
    line 277 MusicBrainz::Server

Request data:

$VAR1 = {
          'query_parameters' => {
                                  'url' => 'http://musicbrainz.org/edit/19953752'
                                },
          'body_parameters' => {}
        };
            

URL: http://musicbrainz.org/edit/19953752/approve?url=http%3A%2F%2Fmusicbrainz.org%2Fedit%2F19953752 


Sort Order: Ascending order - Click to sort in descending order
Oliver Charles added a comment - 25/Jan/13 05:30 PM

Ian McEwen added a comment - 06/Feb/13 09:54 PM

The fix for this has caused our tests to deadlock with themselves, due to the locks test in t/lib/t/MusicBrainz/Server/Data/Edit.pm


Oliver Charles added a comment - 07/Feb/13 05:49 AM

I'll take this up, probably by reverting this for now. Thanks for investigating.