Issue Details (XML | Word | Printable)

Key: MBS-5259
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: Duke Yin
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Track Parser "detect track durations" is broken on releases with DiscIDs, appending lengths to Artist

Created: 03/Sep/12 08:28 AM   Updated: 17/Sep/12 10:29 AM   Resolved: 17/Sep/12 10:29 AM
Component/s: Edit system
Affects Version/s: None
Fix Version/s: 2012-09-17


 Description  « Hide

Trying to paste this tracklist:

1. ABORT//CLEAR - T.M.Revolution (3:24)
2. Out Of Orbit ~Triple ZERO~ (phase shift mix) - T.M.Revolution (4:38)
3. INVOKE -インヴォーク- - T.M.Revolution (4:19)
4. Meteor -ミーティア- - T.M.Revolution (4:11)
5. NEO SPHERE - T.M.Revolution (3:55)
6. BRIGADE - T.M.Revolution (6:00)
7. Juggling ~acoustic GTR "turbo" starter~ - T.M.Revolution (4:21)
8. Tide Moon River - T.M.Revolution (2:15)
9. BOARDING (phase shift armoured version) - T.M.Revolution (5:00)
10. INVOKE -インヴォーク- (TV opening version) - T.M.Revolution (1:31)
11. THUNDERBIRD (version "in the force") - T.M.Revolution (4:49)
12. Heart of Sword - YOAKE MAE (BEFORE DAWN) - T.M.Revolution (4:03)

Into:
http://musicbrainz.org/release/5ac38f64-27ec-3fe0-9c46-727f3537e877/edit

Artists become "T.M.Revolution (x:xx)" both when "Detect track durations" is ticked and when unticked.



Sort Order: Ascending order - Click to sort in descending order
Ian McEwen added a comment - 03/Sep/12 10:40 AM

Change description to use jira's noformat directive


Ian McEwen added a comment - 03/Sep/12 11:53 AM

This appears to be failing because there's a DiscID on the release and thus it's not parsing track times at all (since they can't actually be changed due to the DiscID).

Which also means I'm not sure what to do here – obviously it shouldn't be parsing the track times into the artist field, but it also can't parse them into the duration field.

Proposal:
a.) make the parser only skip the track-duration-parsing part when the checkbox is unchecked, but make sure it bails out later (when setting the duration) if there's a DiscID
b.) add a bit of documentation text to "Detect track durations" noting that while it'll detect track durations, it won't be able to change them if there's a DiscID (not sure exactly how to word this bit of info)

Thoughts?


Ian McEwen added a comment - 03/Sep/12 01:07 PM

(changing description to fit actual problem)


Nicolás Tamargo added a comment - 04/Sep/12 05:22 PM

I'd happily just always drop the durations if the checkbox is unchecked, and make it unable to check (greyed out) if there's a discID. Yes, it is somewhat annoying in the uncommon cases of titles or artists whose name ends in a format that resembles a duration and where there is also no actual duration for the track. But really, how common is that? (and it can still be entered via the normal tracklist post-parsing)


Ian McEwen added a comment - 04/Sep/12 05:28 PM

I think for now I'll just do part a.) of my proposal without b.) (i.e. just make it drop them silently when the box is checked and it can't actually update the durations due to a DiscID)

... and maybe sometime in the future we can just make the track parser less generally stupid


Ian McEwen added a comment - 04/Sep/12 06:21 PM