[#MBS-4727] Regression : Can't add ISWC when adding work - MusicBrainz JIRA

MusicBrainz Server

Regression : Can't add ISWC when adding work

Created: 16/May/12 10:21 AM Updated: 05/Nov/12 04:55 PM Resolved: 30/Oct/12 02:08 PM

Component/s:

Edit system, User interface

Affects Version/s:

None

Fix Version/s:

2012-10-29

Issue Links:

Relates

This issue is related to:

~~MBS-2885~~ Allow more than one ISWC per work

~~MBS-2532~~ Allow more than one IPI per artist

This issue has related issue:

~~MBS-5556~~ Relationship editor : Can't create / add work with ISWC

~~MBS-5147~~ Add/edit work pages can't be seeded with ISWCs

MBS-5442 The work creation widget should allow to create a work with an ISWC

Description

« Hide

ISWC field has disappeared from Add Work page.
Without fixing this regression, adding a work takes 3 times much more time.
*Please fix it the same manner as IPI (the field did not disappear after ~~MBS-2532~~).*

Sort Order:

[ Permalink | « Hide ]

patate12 added a comment - 14/Aug/12 09:35 PM

Here is my quick and dirty fix for those like me who can't wait any longer : create work with its ISWC.

[ Permalink | « Hide ]

Michael Wiencek added a comment - 15/Aug/12 07:44 AM

http://codereview.musicbrainz.org/r/2166/

[ Permalink | « Hide ]

patate12 added a comment - 15/Aug/12 08:19 AM

Hey bitmap, it's greater than IPI edits as you made it generate separate edits !
Thanks very much, this will furthermore prevent a few blockings like MBS-5145.

[ Permalink | « Hide ]

patate12 added a comment - 21/Aug/12 09:39 AM

Hi bitmap (sorry I don't have codereview account), you say that « _If you add ISWCs, it submits a separate Add ISWCs edit {...} If you remove ISWCs, it submits separate Remove ISWC edits for each removal._ » (jira markup syntax is crap, it doesn't even work)
What happens if you edit ISWC ? remove+add ?

[ Permalink | « Hide ]

Michael Wiencek added a comment - 21/Aug/12 11:42 AM

@jesus2099, yeah, it submits a remove+add, because there's no "Edit ISWC" edit type.

[ Permalink | « Hide ]

patate12 added a comment - 21/Aug/12 02:19 PM

That's great, it's fine for me, I just wanted to know. Thanks

[ Permalink | « Hide ]

Oliver Charles added a comment - 25/Sep/12 11:44 AM

The merge window for 2012-10-01 is now closed, so this will have to wait until 2012-10-15.

[ Permalink | « Hide ]

Oliver Charles added a comment - 08/Oct/12 10:05 AM

The window for shipping this to beta testing has closed, so this will have to wait for the next release.

Regression : Can't add ISWC when adding work

Regression : Can't add ISWC when adding work