Issue Details (XML | Word | Printable)

Key: MBS-3957
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: Aurélien Mino
Votes: 2
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

When changing a track duration, if difference is > 10 seconds, recording association should be confirmed or changed

Created: 09/Dec/11 08:41 AM   Updated: 20/Aug/12 09:51 AM  Due: 03/Oct/12   Resolved: 20/Aug/12 09:51 AM
Component/s: Edit system, Release editor
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-08-20


 Description  « Hide

It should happen, in order to preserve data integrity, while editing a release - or adding a new release with reuse of existing tracklist.



Sort Order: Ascending order - Click to sort in descending order
nikki added a comment - 09/Dec/11 06:37 PM

I would even say 15 seconds is too much


Aurélien Mino added a comment - 09/Dec/11 10:36 PM

Right, 10 seconds might be a better value.


Oliver Charles added a comment - 10/Jul/12 07:04 AM

Due to be fixed within the next 3 months. Decided by the scheduling game and http://chatlogs.musicbrainz.org/musicbrainz-devel/2012/2012-07/2012-07-03.html#T19-01-57-842265


Oliver Charles added a comment - 20/Jul/12 09:42 AM

This is in review at http://codereview.musicbrainz.org/r/2076/ and available for testing on http://test.musicbrainz.org/


nikki added a comment - 24/Jul/12 07:42 AM

This really isn't working as expected.

Go to http://beta.musicbrainz.org/release/a0d67108-28a1-4084-b7b4-64ff07f2813e/edit
Go to the tracklist tab.
Add an exclamation mark to the end of track 1's name
Go to the recordings tab

Expected outcome: This is only a minor change to the track name, so no recordings need to be confirmed.
Actual outcome: You're expected to reconfirm ALL the recordings (except the two with lengths set).

1. It's asking people to confirm recordings for tracks they haven't even edited. This will certainly drive people batty if it's not fixed.
2. I can't really tell because of the above, but it would seem it's checking the track time even when the track time hasn't been touched. I'm not sure whether that's good or not, but it's not what this ticket says to do.
3. It sees missing times as a big difference in the time. I don't think that should happen. A missing time means we don't know if the times are similar or not, which is not the same thing as knowing the times are definitely not similar. For the former, you normally want to copy the times to the recordings. For the latter, you normally want to select a different recording.


Oliver Charles added a comment - 01/Aug/12 01:03 PM

This has been reverted from beta.


Oliver Charles added a comment - 03/Aug/12 12:50 PM

Oliver Charles added a comment - 06/Aug/12 10:48 AM

A new version of this is in beta testing.