Issue Details (XML | Word | Printable)

Key: MBS-3112
Type: Improvement Improvement
Status: Decision Required Decision Required
Priority: Normal Normal
Assignee: Unassigned
Reporter: patate12
Votes: 1
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

TAB from "Edit note" doesn't go to "Enter edit" in "Release editor"

Created: 29/Jul/11 09:53 AM   Updated: 02/Feb/13 05:45 PM
Component/s: User interface - needs help
Affects Version/s: Bug fixes, 2011-08-22
Fix Version/s: None


 Description  « Hide

Not really a bug but a small ergonomic flaw.

In most edit types (all single page edits I guess), hitting tabulation (TAB key) when inside the "Edit note" text area will lead you to the "Enter edit" button so that you can hit ENTER right away.

However this ergonomic consistency is not kept for "Release edit" type where hitting TAB will lead you to the red "Cancel" button that makes you loose all your hard work if acting too fast.

Here is the solution from my userjs : Changing tab index without changing layout :

BEFORE 

Edit note
  ↓
Cancel → Previous → Enter edit

AFTER 

                    Edit note
                        ↓
Cancel ← Previous ← Enter edit

Sort Order: Ascending order - Click to sort in descending order
voiceinsideyou made changes - 31/Jul/11 06:55 AM
Field Original Value New Value
Issue Type Bug [ 1 ] Improvement [ 4 ]
Component/s Edit system [ 10001 ]
Component/s User interface [ 10060 ]
[ Permalink | « Hide ]
patate12 added a comment - 22/Aug/11 09:05 AM

I higher the priority as it's making loosing many edits and time and it's a quick fix, just changing button order.

Instead of : Cancel | « Previous | Enter edit
We should get : Enter edit | « Previous | Cancel

At least not having cancel button first because when a keyboard user looses this edit, that concerns many edits in one (release edit).


patate12 made changes - 22/Aug/11 09:05 AM
Priority Normal [ 6 ] Major [ 3 ]
[ Permalink | « Hide ]
patate12 added a comment - 22/Aug/11 10:15 AM

I revert to normal criticality as I found no one else complaining about lost edits like me in the chat logs.
I wrote a fix userjs instead, called Swap cancel and save/submit buttons in release editor, which additionally and optionally asks for cancel confirmation.


patate12 made changes - 22/Aug/11 10:15 AM
Priority Major [ 3 ] Normal [ 6 ]
[ Permalink | « Hide ]
Oliver Charles added a comment - 22/Aug/11 11:07 AM

Except that changing the button order is not the correct solution. The correct solution is to change the tab order, back keep the user interface consistent (tabbing should always favor "next" first). The cancel confirmation seems like a great idea.


Oliver Charles made changes - 22/Aug/11 11:07 AM
Assignee Oliver Charles [ acid2 ] Kuno Woudt [ warp ]
Kuno Woudt made changes - 23/Aug/11 03:02 PM
Fix Version/s Bug fixes, 2011-08-29 [ 10099 ]
Affects Version/s Bug fixes, 2011-08-22 [ 10098 ]
Kuno Woudt made changes - 24/Aug/11 08:14 PM
Status Open [ 1 ] Decision Required [ 10000 ]
[ Permalink | « Hide ]
Kuno Woudt added a comment - 24/Aug/11 08:18 PM

I don't agree the tab order should be changed here. Having tab order flow first to 'enter edit', then to 'cancel' and 'previous' will surprise anyone who expects the default / current tab order (which is a reasonable thing to expect IMO).

IMO cancel can just be removed, I never use it


[ Permalink | « Hide ]
nikki added a comment - 24/Aug/11 09:04 PM

I have to agree that edit note -> (annoyingly placed auto-editor checkbox ->) cancel is not what I expected either. Changing the tab order would give us the same behaviour we had before at least.


Oliver Charles made changes - 14/Sep/11 10:42 AM
Fix Version/s Bug fixes, 2011-09-19 [ 10101 ]
Fix Version/s Bug fixes, 2011-09-12 [ 10099 ]
patate12 made changes - 21/Sep/11 12:25 PM
Link This issue has related issue MBS-1470 [ MBS-1470 ]
Oliver Charles made changes - 21/Sep/11 02:42 PM
Fix Version/s Bug fixes, 2011-09-26 [ 10102 ]
Fix Version/s Bug fixes, 2011-09-19 [ 10101 ]
Oliver Charles made changes - 03/Oct/11 09:26 PM
Fix Version/s Bug fixes, 2011-10-03 [ 10103 ]
Fix Version/s Bug fixes, 2011-09-26 [ 10102 ]
Oliver Charles made changes - 14/Oct/11 04:44 PM
Fix Version/s Bug fixes, 2011-10-25 [ 10106 ]
Fix Version/s Bug fixes, 2011-10-10 [ 10103 ]
Kuno Woudt made changes - 28/Oct/11 09:02 PM
Component/s User interface - needs help [ 10050 ]
Component/s Edit system [ 10001 ]
Component/s User interface [ 10060 ]
Oliver Charles made changes - 14/Nov/11 02:35 PM
Fix Version/s Bug fixes, 2011-11-14 [ 10110 ]
Fix Version/s Bug fixes, 2011-10-25 [ 10106 ]
Oliver Charles made changes - 15/Nov/11 06:53 PM
Fix Version/s Bug fixes, 2011-11-21 [ 10111 ]
Fix Version/s Bug fixes, 2011-11-14 [ 10110 ]
Oliver Charles made changes - 23/Nov/11 05:57 PM
Fix Version/s Bug fixes, 2011-12-05 [ 10119 ]
Fix Version/s Bug fixes, 2011-11-21 [ 10111 ]
Kuno Woudt made changes - 28/Nov/11 09:35 PM
Assignee Kuno Woudt [ warp ]
patate12 made changes - 29/Nov/11 08:52 AM
Link This issue has related issue MBS-1470 [ MBS-1470 ]
Oliver Charles made changes - 08/Dec/11 02:19 PM
Fix Version/s Bug fixes, 2011-12-22 [ 10122 ]
Fix Version/s Bug fixes, 2011-12-05 [ 10119 ]
Oliver Charles made changes - 05/Jan/12 06:55 PM
Fix Version/s Schema change, 2012-01-12 [ 10116 ]
Fix Version/s Bug fixes, 2011-12-22 [ 10122 ]
Oliver Charles made changes - 12/Jan/12 10:27 PM
Fix Version/s Bug fixes, 2012-01-23 [ 10126 ]
Fix Version/s Schema change, 2012-01-12 [ 10116 ]
[ Permalink | « Hide ]
Oliver Charles added a comment - 12/Jan/12 10:43 PM

As this issue has been delayed, I am moving it back to be rescheduled.


Oliver Charles made changes - 12/Jan/12 10:43 PM
Fix Version/s Bug fixes, 2012-01-23 [ 10126 ]
[ Permalink | « Hide ]
patate12 added a comment - 16/Feb/12 10:49 AM

Oliver, That's right is was quite strange swapping buttons.
I changed the (cross-browser)userjs so that it now fixes tab indexes cycle without altering the buttons layout.


patate12 made changes - 26/Oct/12 09:08 PM
Description Not really a bug but a small ergonomic flaw.

In most edit types (all single page edits I guess), hitting tabulation (TAB key) when inside the "Edit note" text area will lead you to the "Enter edit" button so that you can hit ENTER right away.

However this ergonomic consistency is not kept for "Release edit" type where hitting TAB will lead you to the red "Cancel" button that makes you loose all your hard work if acting too fast. 		Not really a bug but a small ergonomic flaw.

In most edit types (all single page edits I guess), hitting tabulation (TAB key) when inside the "Edit note" text area will lead you to the "Enter edit" button so that you can hit ENTER right away.

However this ergonomic consistency is not kept for "Release edit" type where hitting TAB will lead you to the red "Cancel" button that makes you loose all your hard work if acting too fast.

Here is the solution from my [userjs|http://userscripts.org/scripts/show/111023] : Changing tab index without changing layout :

*BEFORE* :(
{noformat}Edit note
  ↓
Cancel → Previous → Enter edit{noformat}

*AFTER* :D
{noformat} Edit note
                        ↓
Cancel ← Previous ← Enter edit{noformat}
[ Permalink | « Hide ]
Nicolás Tamargo added a comment - 02/Feb/13 05:45 PM

The autoeditor checkbox is handy since pressing enter on it does the same than pressing it on Enter Edit. But the couple times I've tried to add releases on sandboxes (i.e. without autoediting privs) I've ended up entering a cancel edit. Note that in the Merge Releases page, the order is the reasonable one: Enter Edit then Cancel. Why is it different in the RE?
Atlassian JIRA (v4.0.1#471) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for MetaBrainz Foundation. Try JIRA - bug tracking software for your team.