Issue Details (XML | Word | Printable)

Key: MBS-3004
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: patate12
Votes: 2
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server
MBS-390

Search for subscribed artists (has been currently dropped)

Created: 13/Jul/11 03:22 PM   Updated: 19/Apr/13 07:26 AM   Resolved: 03/Aug/11 03:21 PM
Component/s: Edit system, Search
Affects Version/s: None
Fix Version/s: Bug fixes, 2011-08-08

Issue Links:
Relates


Sort Order: Ascending order - Click to sort in descending order
Oliver Charles added a comment - 01/Aug/11 09:20 AM

This is now in review at http://codereview.musicbrainz.org/r/1437 and available for testing on http://test.musicbrainz.org/search/edits. Look for the "in subscriptions" option when you choose "artist" or "label" as a search field.


patate12 added a comment - 01/Aug/11 10:02 AM

test.mb.org currently redirects to mb.org (!?)


Oliver Charles added a comment - 01/Aug/11 12:20 PM - edited

Yes, it is a test server, so I was using it for testing That's now fixed.


patate12 added a comment - 01/Aug/11 12:27 PM


Now I get a javascript error "Undefined variable: MB" and "Undefined variable: $"
(opera 11.50 1074 winXP)


Oliver Charles added a comment - 01/Aug/11 12:41 PM

Thanks, I did a sloppy job pushing this update out. Should be working now


patate12 added a comment - 01/Aug/11 01:19 PM - edited

Concerning this, I think it is missing the opposite "is not in my subscription".

Now a little bit off topic but I have very much difficulty to let's say select editor=jesus2099 AND subscribed artist for instance :

1. I click the select, then click the Editor options
2. Some fields appear but the select re-opens
then sometimes :
3a. I click the text appeared field, then the select gets blank
or
3b. I click the text appeared field, then the select doesn't get blank but after search submit, this line disappeared and found no edits
or 3c. I click the text appeared field, then the select doesn't get blank but after search submit, I get error page

Caught exception in MusicBrainz::Server::Controller::Edit->search "Failed query:
	'SELECT edit.* FROM edit JOIN edit_artist edit_artist1 ON edit_artist1.edit = edit.id JOIN editor_subscribe_artist editor_subscribe_artist2 ON editor_subscribe_artist2.artist = edit_artist1.artist WHERE  ((editor_subscribe_artist2.editor = ?) and (editor = ?))
         ORDER BY open_time DESC
         LIMIT 500 OFFSET ?'
	(285909 285909 0)
DBD::Pg::st execute failed: ERROR:  column reference "editor" is ambiguous
LINE 1: ...(editor_subscribe_artist2.editor = '285909') and (editor = '...
                                                             ^ at /home/musicbrainz/musicbrainz-server/script/../lib/Sql.pm line 79.
etc.

Oliver Charles added a comment - 01/Aug/11 01:23 PM

The opposite is a separate ticket, and I'd like to keep it that way as it's quite a tricky problem. I'll look at your other problems now, thanks for testing


Oliver Charles added a comment - 01/Aug/11 01:27 PM

The exception you caused should now be fixed. The others I think are unrelated problems


patate12 added a comment - 01/Aug/11 02:20 PM

Sorry I might be total moron.
I strived a little to achieve my edit search because of the mentionned bug on select that gets re-open and gets reset.
But I managed to have these displayed :

Show me edits that match all of the following conditions:
Editor is jesus2099
Artist in my subscriptions
Created after 2011-07-01

And that eventually "Found 0 edits". Which can't be true.


Oliver Charles added a comment - 01/Aug/11 03:05 PM

Have you checked you have any subscriptions? test.musicbrainz.org does not currently have private data loaded, so you'll need to subscribe to something first. It's a bit awkward I know, hopefully the next time we reload data we can load the private data too!


patate12 added a comment - 01/Aug/11 04:20 PM

Thanks dude, it works great indeed, I can say I'm a moron, no subscriptions !
Have you ever heard of the other problem I described (1, 2, 3a, 3b) or I open a new ticket if not ?


Oliver Charles added a comment - 02/Aug/11 08:26 AM

It sounds like it's all related to the autocomplete JS for editor search, so I think that's a different issue.