Issue Details (XML | Word | Printable)

Key: MBS-2801
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: Duke Yin
Votes: 6
Watchers: 5
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

ModBot thinks a tracklist was changed and so failed a medium edit, but that's not the case

Created: 18/Jun/11 03:09 AM   Updated: 13/Mar/13 04:13 AM   Resolved: 13/Mar/13 04:13 AM
Component/s: Edit system
Affects Version/s: Bug fixes, 2011-06-13
Fix Version/s: Schema Change, 2011-07-11

Issue Links:
Relates


 Description  « Hide

The failed dependency edit: http://musicbrainz.org/edit/14568209
The rest of the edits on the release: http://musicbrainz.org/release/0c755bbb-c9ba-4233-8835-95003472c913/edits

As you can see there were no other edits open/accepted. In fact, there were no other edits besides the Add Release edit. (Unless a cancelled medium edit causes ModBot to claim a tracklist got changed.)



Sort Order: Ascending order - Click to sort in descending order
voiceinsideyou added a comment - 19/Jun/11 05:27 PM

Linking to one of the related issues with failing dependencies. You never know - it may be the cancelled edit! (Want to see if you can replicate?)


Ross Collins added a comment - 21/Jun/11 01:58 PM

I've also been struck by this "bug" on several edits, which were really hard work to get right the first time, so I'm not keen to go through the whole rigmarole again only for it to fail again...

e.g.

http://musicbrainz.org/edit/14553137

Also, somebody else hit this problem:

http://musicbrainz.org/edit/14646619

Is ModBot just too sensitive now?


Ross Collins added a comment - 21/Jun/11 02:12 PM

In the case of my edit it may be related to that old bug whereby track listings were shared between multiple releases as a bunch failed together:

http://musicbrainz.org/edit/14553137
http://musicbrainz.org/edit/14553166
http://musicbrainz.org/edit/14553261
http://musicbrainz.org/edit/14553284


Ryan Torchia added a comment - 23/Jun/11 12:39 AM

I'm also running into this frequently. One situation I know will trigger it is this:

1) Submit an edit for a track name on a release.
2) Submit an edit to merge the recording for that track into another recording.
I don't know if the merge has to involve that specific track or any track on the tracklist.
3) Have the merge edit approved first.

RESULT: The track name edit will fail dependency, even though the edits don't seem to affect each other at all. After the failure, clicking on the Edit History (for I think either the release or recordings) returns an internal error.


Ross Collins added a comment - 23/Jun/11 07:38 AM

The internal error is probably this separate bug:

http://tickets.musicbrainz.org/browse/MBS-2846


Oliver Charles added a comment - 07/Jul/11 12:38 PM

I have made some changes to this code now, and it should only fail if there is an actual conflict of information. This work needs some extensive testing though, and is available for testing at http://test.musicbrainz.org. Please experiment and see what you find!


Oliver Charles added a comment - 18/Jul/11 01:28 PM

I haven't heard any more discussion about this, so I'm going to assume it's now fixed?


Ryan Torchia added a comment - 19/Jul/11 01:04 AM

I think I'm still seeing this, but I'll have to keep a closer eye on it to see if it's appropriate or not. It still seems like a change to a track name will fail if the recording name is changed or merged, which doesn't seem like it should matter (especially if it's the same change). Most of my edits are just capitalization corrections anyway. (I know this doesn't really help much, so I'll definitely try to find some concrete answers.)

BTW, the test.musicbrainz.org site gives me a 502 error.


Duke Yin added a comment - 13/Mar/13 04:12 AM

I don't think this is fixed. See http://tickets.musicbrainz.org/browse/MBS-6015