Issue Details (XML | Word | Printable)

Key: MBS-2306
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: Andrew John Hughes
Votes: 2
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

ws2 implementation doesn't return discids with discid queries

Created: 25/May/11 09:14 PM   Updated: 04/Aug/11 09:31 AM   Resolved: 03/Aug/11 12:01 PM
Component/s: CD support, Web service
Affects Version/s: None
Fix Version/s: Bug fixes, 2011-08-08

Issue Links:
Relates


Sort Order: Ascending order - Click to sort in descending order
Andrew John Hughes added a comment - 25/May/11 09:20 PM

A query for a release:

http://musicbrainz.org/ws/2/release/7057bbc3-ba54-3a8b-aa18-a324f8a63ad8?inc=artist-credits%2Blabels%2Bdiscids%2Brecordings

will return the disc IDs under each medium in a disc-list element.

However, if you query by disc ID, you get a list of releases returned which include mediums with disc IDs other than those requested:

http://musicbrainz.org/ws/2/discid/ukDFYzfdY6xscXSNNt5Mvrbd6go-?cdstubs=no&inc=artist-credits%2Blabels%2Brecordings%20isrcs

and attempting to include the disc IDs:

http://musicbrainz.org/ws/2/discid/ukDFYzfdY6xscXSNNt5Mvrbd6go-?cdstubs=no&inc=artist-credits%2Blabels%2Brecordings%20isrcs%20discids

gives an error:

discids is not a valid option for the inc parameter for the discid resource unless you specify one of the following other inc parameters: releases

which is contrary to http://musicbrainz.org/doc/XML_Web_Service/Version_2

'A discid lookup returns a list of associated releases, the 'inc=' arguments supported are identical to a lookup request for a release.'

If I attempt to add 'releases' to inc as specified:

http://musicbrainz.org/ws/2/discid/ukDFYzfdY6xscXSNNt5Mvrbd6go-?cdstubs=no&inc=artist-credits%2Blabels%2Brecordings%20isrcs%20discids%20releases

I get the error:

'releases is not a valid inc parameter for the discid resource.'

Huh?

How should I be retrieving a disc ID from the web service, such that I know which track list matches the disc? At the moment, it seems I have to do two queries; one by disc ID to get the release ID, then a release ID query which I then filter manually by disc ID. Should there not be a simpler way in which we just get the result from the disc ID query? Should a disc ID query not just return a medium?


Oliver Charles added a comment - 03/Aug/11 11:08 AM

I don't think this is valid any more.

http://musicbrainz.org/ws/2/discid/ukDFYzfdY6xscXSNNt5Mvrbd6go-?cdstubs=no&inc=artist-credits%2Blabels%2Brecordings%20isrcs

Does indeed have disc IDs for all mediums.


Aurélien Mino added a comment - 03/Aug/11 12:01 PM

This has indeed been fixed by http://codereview.musicbrainz.org/r/1378/


Andrew John Hughes added a comment - 04/Aug/11 09:31 AM

This is over two months old

Yes, seems fixed now.