Issue Details (XML | Word | Printable)

Key: SEARCH-199
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Paul Taylor
Reporter: nikki
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Search Server

Search includes empty annotations

Created: 02/Apr/12 02:32 PM   Updated: 08/May/12 08:14 PM   Resolved: 08/May/12 08:14 PM
Component/s: None
Affects Version/s: None
Fix Version/s: 2012-05-15


 Description  « Hide

e.g. http://musicbrainz.org/search?query=name%3A%22%E5%9C%A8%E6%B2%92%E6%9C%89%E9%9B%A8%E6%B0%B4%E6%BB%8B%E6%BD%A4%E7%9A%84%E6%98%9F%E7%90%83%E4%B8%8A%E6%98%AF%E7%84%A1%E6%B3%95%E4%BB%98%E5%87%BA%E6%84%9B%E7%9A%84%E5%90%A7%22&type=annotation&limit=25&advanced=1 is empty but still shows up.

I would personally exclude empty annotations since it doesn't seem to be particularly useful. If for some reason people want to be able to find empty annotations, then I'd like a way of filtering them out.



Paul Taylor added a comment - 02/Apr/12 04:05 PM

It is finding an actual annotation though so I don't see why it shouldn't be listed. The more important question is should we be allowing empty annotations to be added in the first place ?


nikki added a comment - 02/Apr/12 07:30 PM

That's basically the way we delete an annotation (we save all the previous versions of an annotation, so once an entity has an annotation, the only way to get rid of it is to remove all the text).


Paul Taylor added a comment - 02/May/12 09:05 AM

Ok I can either remove them or leave them in. I don't thinks its practical to leave them in but make it easy to filter them out, the only way I can think to do this is is to introduce a new field, one field contains all annotationa including empty ones, the other one doesnt include empty ones but sounds like overkill.


nikki added a comment - 07/May/12 01:39 AM

I'm still in favour of just removing them.


Paul Taylor added a comment - 08/May/12 08:14 PM

FIxed with tests, empty annotations no longer indexed.


Paul Taylor made changes - 08/May/12 08:14 PM
Field Original Value New Value
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s next version [ 10131 ]
Resolution Fixed [ 1 ]