Issue Details (XML | Word | Printable)

Key: PICARD-43
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Michael Wiencek
Reporter: voiceinsideyou
Votes: 7
Watchers: 5
Operations

If you were logged in you would be able to see more operations.
Picard

Extended comparison of existing vs. MB metadata & tags

Created: 16/Sep/11 02:47 AM   Updated: 20/May/12 03:16 AM   Resolved: 08/Mar/12 01:43 AM
Component/s: Tags & Metadata, User Interface
Affects Version/s: 0.15.1
Fix Version/s: 1.0

Issue Links:
Relates
 


 Description  « Hide

In a similar vein to http://bugs.musicbrainz.org/ticket/614 and http://bugs.musicbrainz.org/ticket/1197, Picard really needs a more advanced view to compare metadata than the simple panes at the bottom of the screen which only show the most basic of fields.

As people become more concerned with tagging additional fields (genres, disc numbers, original release dates, for example) this is probably going to become more important.

One option within the existing UI design may be to give the "Details" tab for matched tracks on the right-hand side some sort of diff view (two columns), at least for the metadata that Picard knows about.

Alternatively, perhaps the bottom old/new pane could expand/contract into "more fields" vs "less fields", at the cost of taking lots of real estate and maybe being a bit ugly. The latter at least would allow easy keyboard cycling between tracks in releases to eyeball the diffs.



Sort Order: Ascending order - Click to sort in descending order
Michael Wiencek added a comment - 16/Oct/11 04:09 AM - edited

Alex Mauer added a comment - 02/Nov/11 07:30 PM

I would prefer some kind of inline diff view (similar to what trac, mediawiki, etc. show for changes, over a two-column comparison view.)

Alternatively one of the the simplest ways to do this would be to show the current details view, but italize the text of tags which are different from the originals (possibly with a tooltip showing the original strings for easier comparison than a "spot the differences" two-column view.


Michael Wiencek added a comment - 19/Dec/11 07:05 AM

There's an experimental branch for this feature on git (named tagdiff). Basically, it looks like this: http://i.imgur.com/qTTwO.png

It's still a rough WIP, and has missing features. I'm posting it now for feedback and ideas.


Johannes Weißl added a comment - 12/Jan/12 01:10 PM

I'm using this now since the time you posted this, and it is so great that I can't go back to the main branch... absolutely fantastic! Also, I haven't noticed any bug yet. Maybe you could add back the lookup button under the image.

It would be awesome if this could make it in 1.0!


Michael Wiencek added a comment - 12/Jan/12 07:31 PM

Great, I'm glad you haven't had any trouble with it yet. There are a few changes I still want to push out soon (all of these are regressions with the main branch):

  • Ability to add a new tag
  • Editing an existing single-valued tag with the window editor (to add >1 value)
  • Adding lookup buttons (perhaps it'd be more useful to add small buttons for this anywhere an MBID appears in the tag table?)

Michael Wiencek added a comment - 31/Jan/12 10:37 PM

I added a right-click menu to the table to edit a specific tag/add a new one, and added a lookup button to the toolbar that opens the selected item on MusicBrainz (or searches for it if there's no MBID in the tags).

This feature seems fairly complete now, but let's wait to see if there are any remaining issues.


Johannes Weißl added a comment - 01/Feb/12 04:20 AM

Great! In my opinion this is ready for a pull request! It will receive better testing in the main git branch...


Ian McEwen added a comment - 14/Feb/12 02:34 PM

I'm seeing strange behavior: for my replaygain_* tags, if I select individual tracks I see the expected behavior: data not changing; when I select the album, though, it shows "(missing from 11 items)" (there are 12 in this particular release). I haven't ascertained if it's actually erasing tags, but hopefully not!


Ian McEwen added a comment - 14/Feb/12 02:43 PM

More info: after I save, it looks like it's deleted the replaygain tags, which seems problematic if true. This is true no matter whether I save individually or at the release level, though.

Er, and now that I look after it's saved, it looks like the replaygain stuff is there. Maybe it's just uppercasing the names, or they're there uppercase and it's losing something in translation (they were showing up lowercase in picard). In any case: diffs should account for the equivalence of upper/lower case in vorbis comments


Michael Wiencek added a comment - 08/Mar/12 01:43 AM

Merged tagdiff branch into master yesterday.