|
I would prefer some kind of inline diff view (similar to what trac, mediawiki, etc. show for changes, over a two-column comparison view.) Alternatively one of the the simplest ways to do this would be to show the current details view, but italize the text of tags which are different from the originals (possibly with a tooltip showing the original strings for easier comparison than a "spot the differences" two-column view. There's an experimental branch for this feature on git (named tagdiff). Basically, it looks like this: http://i.imgur.com/qTTwO.png It's still a rough WIP, and has missing features. I'm posting it now for feedback and ideas. I'm using this now since the time you posted this, and it is so great that I can't go back to the main branch... absolutely fantastic! Also, I haven't noticed any bug yet. Maybe you could add back the lookup button under the image. It would be awesome if this could make it in 1.0! Great, I'm glad you haven't had any trouble with it yet.
I added a right-click menu to the table to edit a specific tag/add a new one, and added a lookup button to the toolbar that opens the selected item on MusicBrainz (or searches for it if there's no MBID in the tags). This feature seems fairly complete now, but let's wait to see if there are any remaining issues. Great! In my opinion this is ready for a pull request! It will receive better testing in the main git branch... I'm seeing strange behavior: for my replaygain_* tags, if I select individual tracks I see the expected behavior: data not changing; when I select the album, though, it shows "(missing from 11 items)" (there are 12 in this particular release). I haven't ascertained if it's actually erasing tags, but hopefully not! More info: after I save, it looks like it's deleted the replaygain tags, which seems problematic if true. This is true no matter whether I save individually or at the release level, though. Er, and now that I look after it's saved, it looks like the replaygain stuff is there. Maybe it's just uppercasing the names, or they're there uppercase and it's losing something in translation (they were showing up lowercase in picard). In any case: diffs should account for the equivalence of upper/lower case in vorbis comments Merged tagdiff branch into master yesterday. |
||||||||||||||||||||||||||||||||||||||||||||||||||
Had similar trac tickets http://bugs.musicbrainz.org/ticket/3071
and http://bugs.musicbrainz.org/ticket/3347