[#PICARD-256] All selected tracks are used in the "New Value" column calculations, indicating data will be changed when it won't. - MusicBrainz JIRA

Picard

All selected tracks are used in the "New Value" column calculations, indicating data will be changed when it won't.

Created: 03/Jul/12 04:21 AM Updated: 03/Sep/12 06:08 PM Resolved: 03/Sep/12 06:08 PM

Component/s:

Tags & Metadata, User Interface

Affects Version/s:

1.0

Fix Version/s:

1.1

Environment:

OSX 10.7

Issue Links:

Relates

This issue is related to:

~~PICARD-255~~ The colors and list position used to indicate when tags are being added, changed, or removed is inconsistent when multiple files are selected

Description

« Hide

1) Load one disc a multi-disc set into picard (but not the complete release). Verify the tags are all current.
2) Select the album.

RESULT:
The values in the "Original Value" column are based on the actual files that have been loaded, while the values in the "New Value" column are based on all tracks on the album. This can cause some tags to indicate they need to be changed when they don't.

For example, say you load Disc 2 of a set:

In the Original Value column, the Disc Number will be 2, but in New Value it will say "(different across ## items)". It will also be yellow and listed at the top if "Show Changes First" is enabled.
Say a track on Disc 1 has a Lyricist credit, but nothing on Disc 2 does. The New Value column will indicate that the Lyricist tag needs to be added – it will have (missing from ## items) in green, and will be listed at the top.

Sort Order:

Ryan Torchia made changes - 03/Jul/12 04:21 AM

Field	Original Value	New Value
Link		This issue is related to ~~PICARD-255~~ [ ~~PICARD-255~~ ]

[ Permalink | « Hide ]

Michael Wiencek added a comment - 27/Aug/12 02:57 AM

Are you suggesting "new value" should not take tracks into account at all?

The first issue is a bug that could (and should) definitely be fixed regardless, but the second one seems inherent to the ability to edit track metadata.

Michael Wiencek made changes - 27/Aug/12 03:15 AM

Assignee

Michael Wiencek [ bitmap ]

[ Permalink | « Hide ]

Michael Wiencek added a comment - 03/Sep/12 06:07 PM

I thought about issue #2 a lot more, and only came up with one good solution. When a track is selected, I think it's a mistake to consider its tags as being "added" (i.e. displaying them green, and only in the new value column). There's no real original value for track metadata, which means nothing can be changed either (because there's nothing to compare with).

If a track is selected, both columns will now display the same value in black text (indicating no changes). Tracks shouldn't affect things when calculating what has changed anymore, because tracks can't carry changes to begin with, only files can.

https://github.com/musicbrainz/picard/commit/5a2d849324b68276d70d9902c7148c43b6e9647f

Michael Wiencek made changes - 03/Sep/12 06:08 PM

Status	Open [ 1 ]	Closed [ 6 ]
Fix Version/s		1.0.1 [ 10144 ]
Resolution		Fixed [ 1 ]