[#PICARD-242] Store lyrics language in tags instead of text representation language - MusicBrainz JIRA

Picard

Store lyrics language in tags instead of text representation language

Created: 21/Jun/12 01:17 AM Updated: 06/Sep/12 09:58 AM Resolved: 19/Aug/12 10:53 AM

Component/s:

Tags & Metadata

Affects Version/s:

None

Fix Version/s:

1.1

Issue Links:

Depends

This issue depends on:

~~MBS-4828~~ Work language not returned in release ws requests

Relates

This issue is related to:

~~MBS-1798~~ Lyrics language for works

Description

« Hide

Currently, Picard stores the language of the text representation in the tags. It would be far more useful to store the language of the lyrics instead (now that we can). The old behavior is even wrong according to e.g. the ID3 standard:
"The 'Language' frame should contain the languages of the text or lyrics spoken or sung in the audio."
http://www.id3.org/id3v2.4.0-frames

Sort Order:

Johannes Weißl made changes - 21/Jun/12 01:17 AM

Field	Original Value	New Value
Link		This issue depends on ~~MBS-4828~~ [ ~~MBS-4828~~ ]

Johannes Weißl made changes - 21/Jun/12 01:21 AM

Summary

Store lyrics lange in tags instead of text representation language

Store lyrics language in tags instead of text representation language

nikki made changes - 21/Jun/12 07:11 AM

Link

This issue is related to ~~MBS-1798~~ [ ~~MBS-1798~~ ]

Johannes Weißl made changes - 07/Aug/12 10:35 PM

Assignee

Johannes Weißl [ hrglgrmpf ]

[ Permalink | « Hide ]

Johannes Weißl added a comment - 07/Aug/12 11:14 PM

Pull request is here: https://github.com/musicbrainz/picard/pull/65, opened forum discussion here: http://forums.musicbrainz.org/viewtopic.php?pid=19411

Johannes Weißl made changes - 09/Aug/12 02:36 PM

Status

Open [ 1 ]

Review Submitted [ 5 ]

Johannes Weißl made changes - 19/Aug/12 10:53 AM

Status	Review Submitted [ 5 ]	Closed [ 6 ]
Fix Version/s		1.0.1 [ 10144 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Paul Taylor added a comment - 06/Sep/12 09:14 AM

So where is the language of the text representation now stored then, or have you just dropped saving this data ?

[ Permalink | « Hide ]

Johannes Weißl added a comment - 06/Sep/12 09:58 AM

Yes, it is not saved by default. However, users can do that by something like:

$set(language,%_releaselanguage%)

(or any custom tag)