Issue Details (XML | Word | Printable)

Key: PICARD-19
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Johannes Weißl
Reporter: Luca Salini
Votes: 13
Watchers: 7
Operations

If you were logged in you would be able to see more operations.
Picard

Make possible to choose which tags are written to/deleted from files

Created: 15/Aug/11 01:38 AM   Updated: 23/Apr/12 07:29 PM   Resolved: 23/Apr/12 07:29 PM
Component/s: Tags & Metadata
Affects Version/s: None
Fix Version/s: 1.0

File Attachments: None
Image Attachments:

1. options1.jpg
(53 kB)
Issue Links:
Depends
 


 Description  « Hide

Picard should allow users to specify which tags they want to write to their files instead of just having generic "Clear existing tags" and "save tags to files" options.

Ideally for each tag you could choose whether to

1) Use MB data and leave unchanged if MB has no data
2) Use MB data and delete if MB has no data
3) Leave unchanged

This ticket overrides (at least) http://bugs.musicbrainz.org/ticket/704 and http://bugs.musicbrainz.org/ticket/942.



Sort Order: Ascending order - Click to sort in descending order
Johannes Weißl added a comment - 15/Aug/11 03:44 AM

Yes, this would be extremely useful to preserve ReplayGain tags!


voiceinsideyou added a comment - 15/Aug/11 03:45 AM

If you're transferring tickets from the old tracker please close the old ones as duplicates and comment on them with a link back here.


voiceinsideyou added a comment - 15/Aug/11 03:56 AM

http://bugs.musicbrainz.org/ticket/5509 (Clear existing tags on if not tagged by MB)
http://bugs.musicbrainz.org/ticket/4678 (Preserve replaygain tags)

^^ both have relevant discussion of requirements for this enhancement.


Johannes Weißl added a comment - 12/Jan/12 11:23 AM

I wrote a patch to address the "exclude some tags from being cleared" issue. What do you think?


Luca Salini added a comment - 12/Jan/12 11:34 AM

I was thinking more of a checkbox form, but that's a nice start, too.
If we have to do it this way, I'd still like to have a list of tags for reference somewhere.
Keep up the good work!


Johannes Weißl added a comment - 12/Jan/12 11:40 AM

Well, the problem with checkboxes is that the UI gets very complicated (many, many tags). Also, with checkboxes it is not possible to exclude completely custom tags from being cleared. This UI has the benefit of being very simple, while pretty powerful at the same time.

A comprehensive list of tags is here: http://musicbrainz.org/doc/MusicBrainz_Picard/Tags/Mapping


Marko Sultsing added a comment - 18/Jan/12 11:20 PM

I do like the textfield option, as it allows custom tags. One suggestion I have would be to allow using at least one wildcard_character: *. Useful (at least) for replaygain tags.


Johannes Weißl added a comment - 19/Jan/12 12:56 PM

Yes, this is a good idea! I will implement this!


Johannes Weißl added a comment - 25/Jan/12 07:02 PM

I created a new branch on my github fork, which also has the patches for PICARD-146, PICARD-148 and bitmap's tagdiff branch merged in: https://github.com/weisslj/picard/tree/PICARD-19-test. It would be cool if you could test it .


Alex Mauer added a comment - 07/Mar/12 06:11 PM

Now that tagdiff is in mainline picard, it gives an obvious way forward to fix this: Either a right-click option or a checkbox next to each listed tag, "Don't clear this tag"


Johannes Weißl added a comment - 19/Mar/12 10:27 PM

In review at https://github.com/musicbrainz/picard/pull/30

The "Don't clear this tag" right click option could be easily implemented on top of this (just append it to the text field). I think the text field is required still, otherwise it is not possible to prevent tags from clearing without having a file that has these tags.


nikki added a comment - 20/Mar/12 11:46 AM

FWIW, a right click option would give me the impression it would only apply to the selected files and not permanently.


Johannes Weißl added a comment - 20/Mar/12 03:21 PM

Yes... it could maybe be fixed by using a phrase like "Permanently prevent this tag from being cleared or overwritten with MusicBrainz data". But better make a new ticket for it...

Marko Sultsing: I left out the wildcard thing that was present in PICARD-19-test since I'm not anymore sure it is what people really want. It is not very probably, but I would want to strip "replaygain_blabla_gain", but keep "replaygain_album_gain", so I would never use the wildcard character. Also, wildcards make it more difficult to parse the string if we want to have something like the "right-click to ignore tags permanently thing".


Johannes Weißl added a comment - 23/Apr/12 07:29 PM

I'm marking this as "solved", since my solution is now in the master branch. For any specific enhancement, please open a new ticket (and link it to this!).