[#PICARD-148] Make ID3 TXXX frames available as free-form tags - MusicBrainz JIRA

Picard

Make ID3 TXXX frames available as free-form tags

Created: 20/Jan/12 03:01 AM Updated: 14/Feb/12 01:05 PM Resolved: 14/Feb/12 01:05 PM

Component/s:

Tags & Metadata

Affects Version/s:

None

Fix Version/s:

1.0

Issue Links:

Depends

This issue is a dependency of:

~~PICARD-19~~ Make possible to choose which tags are written to/deleted from files

Description

« Hide

There is a dissymmetry between e.g. Vorbis tags and ID3: Custom vorbis tags (e.g. "moo") are made available as metadata in the GUI, while ID3 TXXX custom tags (e.g. "TXXX:moo") are not.

Sort Order:

[ Permalink | « Hide ]

Lukáš Lalinský added a comment - 20/Jan/12 07:28 AM

I disagree with this. I do not see TXXX frames as equivalent to Vorbis comments.

[ Permalink | « Hide ]

Johannes Weißl added a comment - 20/Jan/12 08:51 AM

Ok, sorry, my justification was unfortunately chosen... even if they are not equivalent, I see only positive effects of this change, no negative ones. Why are you against adding them as free form tags?

[ Permalink | « Hide ]

Lukáš Lalinský added a comment - 20/Jan/12 09:11 AM

Hm, I guess it's not so bad. We do not have a way to deal with tags that contain spaces for example, so this could confuse users, but I guess we can deal with issues like that later. So, you can ignore my comment above.

[ Permalink | « Hide ]

Johannes Weißl added a comment - 20/Jan/12 09:15 AM

Ok, no problem . I was thinking of the space problem already, but you are right, it exists for vorbis right now also... I will further test my prototype implementation and upload it on github once it is ready!

[ Permalink | « Hide ]

Johannes Weißl added a comment - 25/Jan/12 05:30 AM

In review at https://github.com/musicbrainz/picard/pull/26

[ Permalink | « Hide ]

voiceinsideyou added a comment - 14/Feb/12 01:05 PM

Merged by luks in https://github.com/musicbrainz/picard/commit/0dfc4be933cc1cea53c63c7411b7e6f8eb2d57ad