Issue Details (XML | Word | Printable)

Key: PICARD-13
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Michael Wiencek
Reporter: voiceinsideyou
Votes: 4
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
Picard

Edits to metadata in Details... menu not reflected in UI

Created: 13/Aug/11 08:08 AM   Updated: 29/Oct/11 06:15 AM   Resolved: 29/Oct/11 06:15 AM
Component/s: Tags & Metadata, User Interface
Affects Version/s: 0.15.1
Fix Version/s: 0.16

File Attachments: None
Image Attachments:

1. screenshot-1.jpg
(172 kB)


 Description  « Hide

Retrieved http://musicbrainz.org/release/f0d155f1-4769-4e1f-bb7a-2b7be9c8a8a into Picard and matched files to it.

Decided I don't want JAY-Z capitalized; so selected all 12 files and right clicked -> Details...

Changed all artist related entries to the capitalization I wanted.

"New metadata" in bottom right shows updated entries and they were all tagged correctly; however both the album and track titles were not updated in the UI.



Sort Order: Ascending order - Click to sort in descending order
Michael Wiencek added a comment - 13/Aug/11 04:18 PM

Yeah, this is a longstanding annoyance. Qt also allows making the QTreeWidget cells directly-editable by double clicking them, which I think would be neat for the track and artist cells at least. Only that'd break being able to double-click a track and open the details window; but most people probably do that to just edit the artist/track name anyway.


Michael Wiencek added a comment - 20/Oct/11 05:22 AM

This actually seems fairly simple to change, but there's some finer details I'm not sure about:

  • Should it change the track, or file metadata? That is, if you modify say the title of track 1, then drag the file from track 1 back into Unmatched Files, should the now-empty track 1 go back to showing the original title? And if you drag the file back onto track 1, it should once again display the modified name?
  • Multiple files linked to a single track will create a small subtree on the track. In that case, should the track always display the original MB metadata, with only the child items showing the modified user metadata?

voiceinsideyou added a comment - 20/Oct/11 05:51 AM

Should it change the track, or file metadata? That is, if you modify say the title of track 1, then drag the file from track 1 back into Unmatched Files, should the now-empty track 1 go back to showing the original title? And if you drag the file back onto track 1, it should once again display the modified name?

Hmm, I think when you're on the RHS, it should only change the track/album metadata; whereas on the LHS it should just change the file metadata; right? I think you expect that when you drag stuff back to the LHS you're basically saying "all this stuff on the RHS is wrong, let's start again".

I think I've noticed issues related to "sticky" metadata moving between sides, even aside from this particular ticket though; like stuff being stuck in the metadata that was only added as a result of a match. Just anecdotal though, and I can't recall details, so possibly ignore me

Multiple files linked to a single track will create a small subtree on the track. In that case, should the track always display the original MB metadata, with only the child items showing the modified user metadata?

I think so, yes. I guess since it's matched to the album but not the track it might be sensible to show the matched album-level metadata; but not file level stuff? Or show the track-level stuff blanked in the bottom pane? Not sure though. That's getting a bit complicated.

Similar issue if it's on the RHS in the unmatched files for an album (not matched to any tracks; but matched to the album) I guess...


voiceinsideyou added a comment - 20/Oct/11 05:54 AM

Looking back at your question, when you said

drag the file from track 1 back into Unmatched Files

I assumed you meant dragging it back to the left-hand pane/side; not to unmatched files for a particular album on the RHS - just to confirm.


Michael Wiencek added a comment - 20/Oct/11 03:04 PM

Right, that's what I meant. Thanks for the comments. I committed some changes in http://git.musicbrainz.org/gitweb/?p=picard.git;a=commitdiff;h=25567ef8553c9352f8f23bbd8250ea6ed97a5d01 if you'd care to test (or to make sure it's not confusing or if there's any "sticky" metadata issues).


Michael Wiencek added a comment - 29/Oct/11 06:15 AM

This is fixed in 0.16, I forgot to close the ticket.