Issue Details (XML | Word | Printable)

Key: MBS-834
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Oliver Charles
Reporter: nikki
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Weird behaviour of the search checkboxes

Created: 30/Aug/10 11:20 AM   Updated: 10/Apr/12 10:36 AM  Due: 05/Dec/12   Resolved: 10/Apr/12 10:36 AM
Component/s: Search
Affects Version/s: NGS - Beta 2
Fix Version/s: Bug fixes, 2012-04-10


 Description  « Hide

A couple of things...

The first one is pretty simple, just tick "direct search" and notice that "advanced query syntax" is still enabled. If you tick "advanced query syntax", it disables "direct search", but not vice versa. I'm not fond of disabling the boxes because then you have to untick one in order to tick the other, but whatever it does, the behaviour should be consistent at least.

The second is probably several things:
Tick "advanced query syntax" and search for something.
Notice that on the results page, direct search is still enabled when it shouldn't be.
You can then tick direct search (making both enabled).
Untick "advanced query syntax" and it will also untick "direct search".

Maybe we should just have radio buttons or a dropdown... it'd mean including the default indexed search as an option, but at least it would be clear that the options are mutually exclusive, and it wouldn't require any js either...



Sort Order: Ascending order - Click to sort in descending order
Oliver Charles added a comment - 25/Jan/11 01:16 PM

Never got started in the last iteration, I'm going to move it out of this weeks to focus on RC1 bugs



Oliver Charles added a comment - 17/Feb/12 01:53 PM

In review at http://codereview.musicbrainz.org/r/1792/ and in for testing on test.musicbrainz.org