Issue Details (XML | Word | Printable)

Key: MBS-7702
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ulrich Klauer
Reporter: Ulrich Klauer
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Reduce the duplication in link_* macros

Created: 24/Jun/14 02:35 PM   Updated: 07/Jul/14 07:54 PM  Due: 07/Jul/14   Resolved: 07/Jul/14 07:54 PM
Component/s: Refactoring, Templates
Affects Version/s: None
Fix Version/s: 2014-07-07


 Description  « Hide

The various link_artist, link_area, link_editor etc. macros mostly do the same thing, but each has its own code. The common parts should be factored out.

In addition, duplicate conditions such as

'<span class="name-variation">' IF text != '' AND text != artist.name AND action == 'show';
...
'</span>' IF text != '' AND text != artist.name AND action == 'show';

are prone to errors (MBS-7684) and should be combined, too.



Sort Order: Ascending order - Click to sort in descending order