Issue Details (XML | Word | Printable)

Key: MBS-7548
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: Timo Martikainen
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Automatic series ordering doesn't work correctly

Created: 15/May/14 12:21 AM   Updated: 26/May/14 07:47 AM  Due: 26/May/14   Resolved: 26/May/14 07:47 AM
Component/s: None
Affects Version/s: None
Fix Version/s: 2014-05-26


 Description  « Hide

For example on this catalog: https://beta.musicbrainz.org/series/1e174a5e-2955-4013-b8c3-1641f34f26cb

... 5,6,7,9,8,9,10 ... 28,30,34,29,30 ...

There's multiple parts using the same number which is most likely causing the problem.



Sort Order: Ascending order - Click to sort in descending order
Ian McEwen added a comment - 15/May/14 12:50 AM

It looks like the code doesn't properly account for multiple numbers that are the same, yeah: https://github.com/metabrainz/musicbrainz-server/blob/63d9c72910af4cb1646407f9303929c925adfc44/lib/MusicBrainz/Server/Data/Series.pm#L246 will, I think, overwrite which ever it gets first, and thus not update that relationship.


Ian McEwen added a comment - 15/May/14 12:52 AM

(note that presumably in that series, those should be set to numbers '9a' and '9b' – even with the code fixed it won't be able to guarantee any particular predictable ordering when the number columns are identical)