Issue Details (XML | Word | Printable)

Key: MBS-7354
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ulrich Klauer
Reporter: PATATE12
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Internal Server Error in mini relationship editor when a relationship has been removed

Created: 17/Mar/14 10:47 AM   Updated: 26/May/14 07:47 AM  Due: 14/Apr/14   Resolved: 26/May/14 07:47 AM
Component/s: Edit system
Affects Version/s: None
Fix Version/s: 2014-05-26


 Description  « Hide

Artist edit to add some URL failed.

The data you have submitted does not make any changes to the data already present.

 Thank you, your edit (#26776535) has been automatically accepted and applied. 
Internal Server Error

Oops, something went wrong!

Error: 

Caught exception in MusicBrainz::Server::Controller::Artist->edit "Can't call method "link" on an undefined value at lib/MusicBrainz/Server/Controller/Role/EditExternalLinks.pm line 170,  line 3.
 at lib/Sql.pm line 320"



Stack trace:
line 19 MusicBrainz::Server::Model::MB
line 202 MusicBrainz::Server::Controller
line 133 MusicBrainz::Server::Controller::Role::EditExternalLinks
line 133 MusicBrainz::Server::Controller::Role::EditExternalLinks
line 53 MusicBrainz::Server::Controller::Role::Edit
line 511 MusicBrainz::Server::Controller::Artist
line 338 MusicBrainz::Server
line 312 MusicBrainz::Server
line 339 MusicBrainz::Server
line 353 MusicBrainz::Server
line 398 MusicBrainz::Server


Request data: 
$VAR1 = {
          'query_parameters' => {},
          'body_parameters' => {
                                 'edit-artist.end_area.name' => '',
                                 'edit-artist.begin_area.gid' => '',
                                 'edit-artist.url.3.link_type_id' => '189',
                                 'edit-artist.url.7.text' => 'http://sebtaylor.bandcamp.com/',
                                 'edit-artist.url.4.text' => 'http://itunes.apple.com/artist/kaya-project/',
                                 'edit-artist.period.end_date.day' => '',
                                 'edit-artist.url.8.link_type_id' => '',
                                 'edit-artist.name' => 'Kaya Project',
                                 'edit-artist.begin_area.name' => '',
                                 'edit-artist.url.4.link_type_id' => '176',
                                 'edit-artist.url.1.link_type_id' => '183',
                                 'edit-artist.area.name' => 'London',
                                 'edit-artist.url.8.text' => '',
                                 'edit-artist.url.0.link_type_id' => '180',
                                 'edit-artist.end_area.gid' => '',
                                 'edit-artist.gender_id' => '',
                                 'edit-artist.ipi_codes.0' => '',
                                 'edit-artist.url.5.link_type_id' => '179',
                                 'edit-artist.url.2.text' => 'https://www.facebook.com/pages/Kaya-Project/287445823535',
                                 'edit-artist.edit_note' => 'from \'\'\'OHP\'\'\' http://www.interchill.com/artist.php?rid=6
http://www.facebook.com/pages/Kaya-Project/287445823535?ref=ts',
                                 'edit-artist.url.1.text' => 'http://www.interchill.com/artist.php?rid=6',
                                 'edit-artist.period.end_date.month' => '',
                                 'edit-artist.url.2.link_type_id' => '192',
                                 'edit-artist.area_id' => '1178',
                                 'edit-artist.url.0.relationship_id' => '226102',
                                 'edit-artist.url.7.link_type_id' => '718',
                                 'edit-artist.url.5.text' => 'http://en.wikipedia.org/wiki/Seb_Taylor',
                                 'edit-artist.area.gid' => 'f03d09b3-39dc-4083-afd6-159e3f0d462f',
                                 'edit-artist.period.end_date.year' => '',
                                 'edit-artist.comment' => '',
                                 'edit-artist.end_area_id' => '',
                                 'edit-artist.url.3.text' => 'https://myspace.com/sebastiantaylor',
                                 'edit-artist.isni_codes.0' => '',
                                 'edit-artist.url.0.text' => 'http://www.discogs.com/artist/157927',
                                 'edit-artist.url.6.link_type_id' => '180',
                                 'edit-artist.begin_area_id' => '',
                                 'edit-artist.period.begin_date.year' => '',
                                 'edit-artist.url.6.text' => 'http://www.discogs.com/artist/567452',
                                 'edit-artist.period.begin_date.month' => '',
                                 'edit-artist.sort_name' => 'Kaya Project',
                                 'edit-artist.type_id' => '1',
                                 'edit-artist.url.1.relationship_id' => '850189',
                                 'edit-artist.period.begin_date.day' => ''
                               }
        };
            


Host: pingu 

URL: https://musicbrainz.org/artist/f2a5a441-bc7a-43c3-bdbe-c6c4c8010c48/edit 

We're terribly sorry for this problem. Please wait a few minutes and repeat your request — the problem may go away. 

If the problem persists, please report a bug and include any error message that is shown above. 

Please be sure to include the stack trace and request data shown above!

If i click the edit link it says

Edit Not Found

Sorry, we could not find an edit with that edit ID. You may wish to try and perform an edit search instead.

So i added them by hand one by one.
Then I need to edit artist (→male) and this now fails with kind of same error :

The data you have submitted does not make any changes to the data already present.

 Thank you, your edit (#26776535) has been automatically accepted and applied. 
Internal Server Error

Oops, something went wrong!

Error: 

Caught exception in MusicBrainz::Server::Controller::Artist->edit "Can't call method "link" on an undefined value at lib/MusicBrainz/Server/Controller/Role/EditExternalLinks.pm line 170,  line 3.
 at lib/Sql.pm line 320"



Stack trace:
line 19 MusicBrainz::Server::Model::MB
line 202 MusicBrainz::Server::Controller
line 133 MusicBrainz::Server::Controller::Role::EditExternalLinks
line 133 MusicBrainz::Server::Controller::Role::EditExternalLinks
line 53 MusicBrainz::Server::Controller::Role::Edit
line 511 MusicBrainz::Server::Controller::Artist
line 338 MusicBrainz::Server
line 312 MusicBrainz::Server
line 339 MusicBrainz::Server
line 353 MusicBrainz::Server
line 398 MusicBrainz::Server


Request data: 
$VAR1 = {
          'query_parameters' => {},
          'body_parameters' => {
                                 'edit-artist.end_area.name' => '',
                                 'edit-artist.begin_area.gid' => '',
                                 'edit-artist.url.3.link_type_id' => '189',
                                 'edit-artist.url.7.text' => 'http://sebtaylor.bandcamp.com/',
                                 'edit-artist.url.4.text' => 'http://itunes.apple.com/artist/kaya-project/',
                                 'edit-artist.period.end_date.day' => '',
                                 'edit-artist.url.8.link_type_id' => '',
                                 'edit-artist.name' => 'Kaya Project',
                                 'edit-artist.begin_area.name' => '',
                                 'edit-artist.url.4.link_type_id' => '176',
                                 'edit-artist.url.1.link_type_id' => '183',
                                 'edit-artist.area.name' => 'London',
                                 'edit-artist.url.8.text' => '',
                                 'edit-artist.url.0.link_type_id' => '180',
                                 'edit-artist.end_area.gid' => '',
                                 'edit-artist.gender_id' => '',
                                 'edit-artist.ipi_codes.0' => '',
                                 'edit-artist.url.5.link_type_id' => '179',
                                 'edit-artist.url.2.text' => 'https://www.facebook.com/pages/Kaya-Project/287445823535',
                                 'edit-artist.edit_note' => 'from \'\'\'OHP\'\'\' http://www.interchill.com/artist.php?rid=6
http://www.facebook.com/pages/Kaya-Project/287445823535?ref=ts',
                                 'edit-artist.url.1.text' => 'http://www.interchill.com/artist.php?rid=6',
                                 'edit-artist.period.end_date.month' => '',
                                 'edit-artist.url.2.link_type_id' => '192',
                                 'edit-artist.area_id' => '1178',
                                 'edit-artist.url.0.relationship_id' => '226102',
                                 'edit-artist.url.7.link_type_id' => '718',
                                 'edit-artist.url.5.text' => 'http://en.wikipedia.org/wiki/Seb_Taylor',
                                 'edit-artist.area.gid' => 'f03d09b3-39dc-4083-afd6-159e3f0d462f',
                                 'edit-artist.period.end_date.year' => '',
                                 'edit-artist.comment' => '',
                                 'edit-artist.end_area_id' => '',
                                 'edit-artist.url.3.text' => 'https://myspace.com/sebastiantaylor',
                                 'edit-artist.isni_codes.0' => '',
                                 'edit-artist.url.0.text' => 'http://www.discogs.com/artist/157927',
                                 'edit-artist.url.6.link_type_id' => '180',
                                 'edit-artist.begin_area_id' => '',
                                 'edit-artist.period.begin_date.year' => '',
                                 'edit-artist.url.6.text' => 'http://www.discogs.com/artist/567452',
                                 'edit-artist.period.begin_date.month' => '',
                                 'edit-artist.sort_name' => 'Kaya Project',
                                 'edit-artist.type_id' => '1',
                                 'edit-artist.url.1.relationship_id' => '850189',
                                 'edit-artist.period.begin_date.day' => ''
                               }
        };
            


Host: pingu 

URL: https://musicbrainz.org/artist/f2a5a441-bc7a-43c3-bdbe-c6c4c8010c48/edit 

We're terribly sorry for this problem. Please wait a few minutes and repeat your request — the problem may go away. 

If the problem persists, please report a bug and include any error message that is shown above. 

Please be sure to include the stack trace and request data shown above!

if i click the edit link, it says :

Edit Not Found

Sorry, we could not find an edit with that edit ID. You may wish to try and perform an edit search instead.



Sort Order: Ascending order - Click to sort in descending order
PATATE12 added a comment - 17/Mar/14 10:55 AM

after several tries i managed to make the edits...


Ulrich Klauer added a comment - 17/Mar/14 10:56 AM

What was the URL?


PATATE12 added a comment - 17/Mar/14 11:20 AM - edited

i changed JIRA markup quote→code as it was showing Unknown macro instead of request parameters.
now you can see all the URL, i was adding several URL at once, none had red warning.
I think i saw an error message about url.3 but i'm really not sure if i remember correctly as i don't see it up-there......


Ulrich Klauer added a comment - 17/Mar/14 11:38 AM

Ah, this "unknown macro" stuff was from JIRA, that explains a bit.
(Another confusing issue: Why are times in the Activity Stream in UTC+1 for me, but times here on the issue page are in UTC??)

Did you by any chance first enter https://musicbrainz.org/edit/26776458, then open the artist edit page, then cancel said edit (from a separate tab), then submit the edit page?


PATATE12 added a comment - 17/Mar/14 11:51 AM

Almost but i did reload the edit page until the cancelled URL would vanish, before I would try to edit again......
But it's true that I had two tabs open in the end so maybe it was all my confusion... I suggest to close this ticket until it happens again, no ?


Ulrich Klauer added a comment - 17/Mar/14 09:08 PM

No, the edit page assumes that the set of URLs can't change while the page is open, which is obviously wrong. It should handle that case more graciously, not by throwing an ISE.