Issue Details (XML | Word | Printable)

Key: MBS-5728
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: Oliver Charles
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Possible to enter 'edit release group' edits that fail to apply due to spaces in artist credits

Created: 03/Jan/13 10:36 AM   Updated: 11/Feb/13 11:40 AM   Resolved: 11/Feb/13 11:40 AM
Component/s: None
Affects Version/s: None
Fix Version/s: 2013-02-11


 Description  « Hide

http://musicbrainz.org/edit/20046199 was opened Dec 11th, but ModBot is unable to close it because the second join phrase contains multiple spaces.



Sort Order: Ascending order - Click to sort in descending order
Oliver Charles added a comment - 03/Jan/13 10:38 AM

http://musicbrainz.org/edit/20226597 is another offender, this one created Dec 23.


Ian McEwen added a comment - 03/Jan/13 10:57 AM

There seem to be other places we aren't cleaning up submitted artist credits, some of which I may not know how to do. I'll record those here, and put the rest on CR.


Ian McEwen added a comment - 03/Jan/13 11:03 AM

Release Groups I'm copying from recordings, i.e. putting it into the 'around initialize' or 'sub initialize' blocks. Other things that I'm not sure how to fix, and will leave for others:

We don't seem to clean track artist credits in Edit Medium and Create Medium edits, and I can't find where I could add a call to clean_submitted_artist_credit.

We don't seem to clean up standalone recordings (Edit::Recording::Create).

I don't see cleanup in Edit::Release::Create, though ::Edit has it.

That covers everything that uses ArtistCreditDefinition from MB::S::Edit::Types. Codereview incoming for what I could get.


Ian McEwen added a comment - 03/Jan/13 11:08 AM

Ian McEwen added a comment - 05/Jan/13 04:39 AM

oliver opposed my fix, so I'll unassign this and someone else can fix it


Oliver Charles added a comment - 22/Jan/13 12:50 PM