http://musicbrainz.org/edit/20046199 was opened Dec 11th, but ModBot is unable to close it because the second join phrase contains multiple spaces.
http://musicbrainz.org/edit/20226597 is another offender, this one created Dec 23.
There seem to be other places we aren't cleaning up submitted artist credits, some of which I may not know how to do. I'll record those here, and put the rest on CR.
Release Groups I'm copying from recordings, i.e. putting it into the 'around initialize' or 'sub initialize' blocks. Other things that I'm not sure how to fix, and will leave for others:
We don't seem to clean track artist credits in Edit Medium and Create Medium edits, and I can't find where I could add a call to clean_submitted_artist_credit.
We don't seem to clean up standalone recordings (Edit::Recording::Create).
I don't see cleanup in Edit::Release::Create, though ::Edit has it.
That covers everything that uses ArtistCreditDefinition from MB::S::Edit::Types. Codereview incoming for what I could get.
oliver opposed my fix, so I'll unassign this and someone else can fix it
In review again at https://github.com/metabrainz/musicbrainz-server/pull/14