Issue Details (XML | Word | Printable)

Key: MBS-5614
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: nikki
Votes: 1
Watchers: 0

If you were logged in you would be able to see more operations.
MusicBrainz Server

Links to edit notes to other edit notes always use http

Created: 26/Nov/12 02:44 PM   Updated: 28/Jan/13 10:15 AM   Resolved: 28/Jan/13 10:15 AM
Component/s: None
Affects Version/s: None
Fix Version/s: 2013-01-28

 Description  « Hide

The link in the edit note should point to https://...

Sort Order: Ascending order - Click to sort in descending order
Ian McEwen added a comment - 27/Nov/12 05:20 AM

PATATE12 added a comment - 27/Nov/12 07:38 PM

Why do not we use links starting from slash /... ?
We would not have to check every this or that.

Ian McEwen added a comment - 27/Nov/12 08:16 PM

It depends on the place, and what the link is to. For this particular task, that probably would work (it's not how I did it – I used scheme-independent links, i.e. '//$server/$path' – but that's not important), but for example linking to the wiki (on a different domain) does require using the // syntax or manually detecting the https vs. http. Coverart is another example of a place where, since we're linking to external domains that may or may not support https, we need to know what the domain supports and be explicit about the protocol used.