Issue Details (XML | Word | Printable)

Key: MBS-5586
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: High High
Assignee: Kuno Woudt
Reporter: Nicolás Tamargo
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

ISE when trying to submit an "Edit artist" edit with no changes

Created: 16/Nov/12 12:38 AM   Updated: 28/Jan/13 10:15 AM   Resolved: 28/Jan/13 10:15 AM
Component/s: None
Affects Version/s: None
Fix Version/s: 2013-01-28

Issue Links:
Resolution
 


 Description  « Hide

MB will nicely print the banner that says "The data you have submitted does not make any changes to the data already present", which is good, and also give an ISE under it, which is not so good.



Sort Order: Ascending order - Click to sort in descending order
Ian McEwen added a comment - 16/Nov/12 12:45 PM

Not sure how much work I'll be able to do here, so I'll log what I discover to comments:

  • line 143 of MB::S::Controller calls $opts{post_creation} unconditionally; it should probably only do this if $edit is defined, since Controller::Artist then tries to call ->id on the value it gets in post_creation (which is the actual ISE that happens)
  • I'm not sure what happens after (yet), it's possible there's other ISEs once that's fixed

Kuno Woudt added a comment - 03/Jan/13 11:02 AM