[#MBS-5478] Can't unselect all recordings / works - MusicBrainz JIRA

MusicBrainz Server

Can't unselect all recordings / works

Created: 18/Oct/12 10:08 AM Updated: 30/Oct/12 02:08 PM Resolved: 30/Oct/12 02:08 PM

Component/s:

None

Affects Version/s:

Schema change, 2012-10-15

Fix Version/s:

2012-10-29

Description

« Hide

It seems the last release broke the (un)select all toggle in, for example, http://musicbrainz.org/artist/49ae5227-605a-47a8-9b8e-cd89bf01a97c/works - clicking once does select all, but clicking again does no longer unselect them.

Sort Order:

[ Permalink | « Hide ]

kovacsur added a comment - 18/Oct/12 11:08 AM

Appears to be caused by line 30 in root/static/scripts/common/MB/Control/SelectAll.js which tries to set the attribute "checked" to undefined. Using .prop instead of .attr will fix it.

[ Permalink | « Hide ]

kovacsur added a comment - 18/Oct/12 12:46 PM

http://codereview.musicbrainz.org/r/2404/

kovacsur made changes - 18/Oct/12 12:46 PM

Field	Original Value	New Value
Status	Open [ 1 ]	Review Submitted [ 5 ]

Ian McEwen made changes - 18/Oct/12 09:55 PM

Assignee

kovacsur [ kovacsur ]

Ian McEwen made changes - 18/Oct/12 09:55 PM

Status

Review Submitted [ 5 ]

In Beta Testing [ 10002 ]

Ian McEwen made changes - 18/Oct/12 09:55 PM

Fix Version/s

2012-10-29 [ 10157 ]

Oliver Charles made changes - 30/Oct/12 02:08 PM

Status	In Beta Testing [ 10002 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]