[#MBS-5415] "Types:" (under cover art) should often be in singular - MusicBrainz JIRA

MusicBrainz Server

"Types:" (under cover art) should often be in singular

Created: 03/Oct/12 12:20 PM Updated: 08/Jan/13 06:03 AM Resolved: 16/Oct/12 07:55 PM

Component/s:

Cover art, Data display

Affects Version/s:

None

Fix Version/s:

Schema change, 2012-10-15

Description

« Hide

If given image only belongs to a single type, then it shouldn't have the plural "Types:" in its description.
E.g. these look weird: "Types: Front", "Types: Back" and these don't: "Types: Back, Spine", "Types: Front, Sticker".

Or the "Types:" part could just be dropped from that context, leaving only "Front", "Back, Spine", etc.

Sort Order:

Ian McEwen made changes - 03/Oct/12 11:52 PM

Field	Original Value	New Value
Assignee		Ian McEwen [ ianmcorvidae ]

[ Permalink | « Hide ]

Ian McEwen added a comment - 03/Oct/12 11:55 PM

http://codereview.musicbrainz.org/r/2376/

Ian McEwen made changes - 03/Oct/12 11:55 PM

Status

Open [ 1 ]

Review Submitted [ 5 ]

Ian McEwen made changes - 04/Oct/12 09:29 PM

Status

Review Submitted [ 5 ]

In Beta Testing [ 10002 ]

Ian McEwen made changes - 04/Oct/12 09:29 PM

Fix Version/s

Schema change, 2012-10-15 [ 10118 ]

Oliver Charles made changes - 16/Oct/12 07:55 PM

Status	In Beta Testing [ 10002 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Ian McEwen added a comment - 08/Jan/13 06:03 AM

So, this has turned out to be a gigantic pain in the ass, because the strings don't work properly with i18n. Not to mention that it's not strictly wrong to label a list of one thing as "Types", given that it can have more entries.

In any case, this is getting reverted as part of my current i18n-fixes branch.