|
Aurélien Mino made changes - 04/Sep/12 06:06 PM
I'd say: don't include @rel anywhere, excepted for images on the release/cover-art page (minus the one in the sidebar of course). Hmm... I didn't see you've mentioned collection... but I'm not sure it would really be useful there. The stuff that displays it for collections isn't even shipped yet AFAIK, worth noting. But I'm fine with only including @rel on the release coverart page for now and seeing if people want it elsewhere; you're right about the original intent, I was just wondering if it'd be possible to pre-empt some tickets by putting it more places than just there Actually, here's one that may be helpful: the reorder cover art page. Thoughts?
Ian McEwen made changes - 04/Sep/12 10:23 PM
Ian McEwen made changes - 04/Sep/12 10:23 PM
Indeed, this one make sense too. Good catch!
Ian McEwen made changes - 04/Sep/12 10:56 PM
Wouldn't it be easier to keep putting @rel on everything, but changing the selector to require all elements to be in some sort of 'grouping container'? ocharles: thickbox groups by what has a shared rel attribute. In general I think it's probably not a good idea to be screwing with our third-party code (except for the bugfix I had to make), meaning that this is the way to do it.
Oliver Charles made changes - 10/Sep/12 10:41 AM
Oliver Charles made changes - 17/Sep/12 10:40 AM
Oliver Charles made changes - 17/Sep/12 11:08 AM
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Question: currently every call to display_artwork adds the @rel; is there anywhere else we shouldn't be? I'm not sure how useful "page through all the images on this page of edits" is (but it's not obviously wrong); "page through all the covers within this collection" seems like it should stay... not sure what else.