Issue Details (XML | Word | Printable)

Key: MBS-5263
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: Aurélien Mino
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Cover art from sidebar should not be included in the set of images when you're navigating through zoomed cover arts

Created: 04/Sep/12 06:06 PM   Updated: 17/Sep/12 11:08 AM   Resolved: 17/Sep/12 11:08 AM
Component/s: None
Affects Version/s: None
Fix Version/s: 2012-09-17

Issue Links:
Relates
 



Aurélien Mino made changes - 04/Sep/12 06:06 PM
Field Original Value New Value
Link This issue is related to MBS-4465 [ MBS-4465 ]
Ian McEwen added a comment - 04/Sep/12 07:08 PM

Question: currently every call to display_artwork adds the @rel; is there anywhere else we shouldn't be? I'm not sure how useful "page through all the images on this page of edits" is (but it's not obviously wrong); "page through all the covers within this collection" seems like it should stay... not sure what else.


Aurélien Mino added a comment - 04/Sep/12 07:27 PM

I'd say: don't include @rel anywhere, excepted for images on the release/cover-art page (minus the one in the sidebar of course).
How does that sounds?


Aurélien Mino added a comment - 04/Sep/12 07:29 PM

Hmm... I didn't see you've mentioned collection... but I'm not sure it would really be useful there.
I think the original intent was mainly "page through all the images of one release".


Ian McEwen added a comment - 04/Sep/12 07:53 PM

The stuff that displays it for collections isn't even shipped yet AFAIK, worth noting. But I'm fine with only including @rel on the release coverart page for now and seeing if people want it elsewhere; you're right about the original intent, I was just wondering if it'd be possible to pre-empt some tickets by putting it more places than just there


Ian McEwen added a comment - 04/Sep/12 10:19 PM

Actually, here's one that may be helpful: the reorder cover art page. Thoughts?


Ian McEwen made changes - 04/Sep/12 10:23 PM
Assignee Ian McEwen [ ianmcorvidae ]
Ian McEwen made changes - 04/Sep/12 10:23 PM
Status Open [ 1 ] In Progress [ 3 ]
Aurélien Mino added a comment - 04/Sep/12 10:39 PM

Indeed, this one make sense too. Good catch!


Ian McEwen made changes - 04/Sep/12 10:56 PM
Status In Progress [ 3 ] Review Submitted [ 5 ]
Oliver Charles added a comment - 05/Sep/12 10:10 AM

Wouldn't it be easier to keep putting @rel on everything, but changing the selector to require all elements to be in some sort of 'grouping container'?


Ian McEwen added a comment - 05/Sep/12 04:47 PM

ocharles: thickbox groups by what has a shared rel attribute. In general I think it's probably not a good idea to be screwing with our third-party code (except for the bugfix I had to make), meaning that this is the way to do it.


Oliver Charles made changes - 10/Sep/12 10:41 AM
Fix Version/s 2012-10-01 [ 10153 ]
Oliver Charles made changes - 17/Sep/12 10:40 AM
Status Review Submitted [ 5 ] In Beta Testing [ 10002 ]
Oliver Charles made changes - 17/Sep/12 11:08 AM
Status In Beta Testing [ 10002 ] Closed [ 6 ]
Fix Version/s 2012-09-17 [ 10152 ]
Fix Version/s 2012-10-01 [ 10153 ]
Resolution Fixed [ 1 ]