|
Oliver Charles made changes - 29/Aug/12 11:38 AM
Oliver Charles made changes - 29/Aug/12 11:38 AM
Oliver Charles made changes - 29/Aug/12 11:38 AM
patate12 made changes - 29/Aug/12 11:43 AM
In review with http://codereview.musicbrainz.org/r/2220/
Oliver Charles made changes - 29/Aug/12 11:43 AM
Oliver :
Why not just sorting by ID ? Because open time is a more correct sort parameter. Oliver: I think the point he's making is that sorting by id will/should already sort it by open_time anyway, so including both is a bit redundant (and possibly inefficient, depending how smart postgresql's query planner is – I don't remember enough about the implementation of ORDER BY to say). edit: I doubt it makes that much of a real difference, note, but I do think the question is reasonable, since it's producing extra code that probably doesn't have any actual effect. No, id's are simply a unique integer, the fact that they are ordered is accidental. Open time is the correct thing to order on, so that should be our primary mode of sorting.
Oliver Charles made changes - 03/Sep/12 11:25 AM
Oliver Charles made changes - 17/Sep/12 10:29 AM
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
Changing to reflect the actual bug