[#MBS-5205] Text diff incorrectly highlights first word that didn't change - MusicBrainz JIRA

MusicBrainz Server

Text diff incorrectly highlights first word that didn't change

Created: 24/Aug/12 02:17 PM Updated: 20/Mar/13 11:38 AM

Component/s:

Edit system

Affects Version/s:

Bug fixes, 2012-08-20

Fix Version/s:

None

File Attachments:

None

Image Attachments:

1. diff-first-word-bug.png
(13 kB)

Issue Links:

Duplicate

This issue is duplicated by:

~~MBS-3576~~ Diff display for medium edits (and others?) displays differences wrong

Description

« Hide

When removing a few words from the beginning of some piece of text, the edit diff also incorrectly flags the first word that didn't actually change.

For example, when changing "The Only Michael - Someone Else's Fur" to "Someone Else's Fur", then the diff tool also highlights "Someone" in both versions, although it didn't change.

Example edits:
http://musicbrainz.org/edit/18645604
http://musicbrainz.org/edit/18645603

Sort Order:

Oliver Charles made changes - 04/Sep/12 03:22 PM

Field	Original Value	New Value
Status	Open [ 1 ]	Review Submitted [ 5 ]

[ Permalink | « Hide ]

Oliver Charles added a comment - 04/Sep/12 03:22 PM

In review at http://codereview.musicbrainz.org/r/2247/diff/#index_header

Oliver Charles made changes - 04/Sep/12 04:16 PM

Status

Review Submitted [ 5 ]

In Beta Testing [ 10002 ]

Oliver Charles made changes - 04/Sep/12 04:16 PM

Fix Version/s

2012-09-17 [ 10152 ]

[ Permalink | « Hide ]

Ian McEwen added a comment - 10/Sep/12 10:23 AM

Assigning to ocharles, linked codereview is him.

Ian McEwen made changes - 10/Sep/12 10:23 AM

Assignee

Oliver Charles [ acid2 ]

Oliver Charles made changes - 17/Sep/12 10:29 AM

Status	In Beta Testing [ 10002 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Frederik "Freso" S. Olesen added a comment - 11/Oct/12 12:12 PM

The issue is still there if you prepend something to a string; see e.g. https://musicbrainz.org/edit/19278023

Frederik "Freso" S. Olesen made changes - 11/Oct/12 12:12 PM

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Reopened [ 4 ]

[ Permalink | « Hide ]

Oliver Charles added a comment - 15/Oct/12 01:34 PM

I'm surprised this issue still happens, the original fix (commit 89afb8383ca8daa61) was reverted (commit 14e74670e2cf).

[ Permalink | « Hide ]

Ian McEwen added a comment - 20/Mar/13 11:37 AM

fix version here is clearly wrong

Ian McEwen made changes - 20/Mar/13 11:37 AM

Fix Version/s

2012-09-17 [ 10152 ]

Ian McEwen made changes - 20/Mar/13 11:38 AM

Link

This issue is duplicated by ~~MBS-3576~~ [ ~~MBS-3576~~ ]