[#MBS-5121] TuneCore song IDs are permitted in ISRC fields - MusicBrainz JIRA

MusicBrainz Server

TuneCore song IDs are permitted in ISRC fields

Created: 09/Aug/12 10:22 PM Updated: 23/Sep/12 03:03 AM Resolved: 23/Sep/12 03:02 AM

Component/s:

Edit system

Affects Version/s:

None

Fix Version/s:

Bug fixes, 2012-09-03

Issue Links:

Relates

This issue has related issue:

~~MBS-5346~~ TuneCore blocking blocks valid ISRCs

Description

« Hide

Anything starting with "TC" is not a valid ISRC, per this email: http://lists.musicbrainz.org/pipermail/musicbrainz-style/2012-April/015191.html

Sort Order:

[ Permalink | « Hide ]

Kai Kasurinen added a comment - 23/Sep/12 02:53 AM

adding FITCR1000075 is not possible anymore ("This is not a valid ISRC. If this code starts with "TC", it is a TuneCore ID, which should be put into the annotation instead.")

—
DiscID: DAeHAlVJ8pXTcZTbtK1_Be5cYLI-
Tracks on Disc: 12
2012-09-23 05:40:29,674 DEBUG GET http://musicbrainz.org/ws/1/release/?type=xml&discid=DAeHAlVJ8pXTcZTbtK1_Be5cYLI-
2012-09-23 05:40:32,177 DEBUG GET http://musicbrainz.org/ws/1/release/eae6fd35-2c41-44d5-936d-c5509f4864b4?type=xml&inc=tracks+isrcs+artist+discs
Artist: Maria Ylipää & Emma Salokoski
Release: Omani uni

found new ISRC for track 1: FITCR1000075
found new ISRC for track 2: FITCR1000076
found new ISRC for track 3: FITCR1000077
found new ISRC for track 4: FITCR1000078
found new ISRC for track 5: FITCR1000079
found new ISRC for track 6: FITCR1000080
found new ISRC for track 7: FITCR1000081
found new ISRC for track 8: FITCR1000082
found new ISRC for track 9: FITCR1000083
found new ISRC for track 10: FITCR1000084
found new ISRC for track 11: FITCR1000085
found new ISRC for track 12: FITCR1000086

Is this correct? [y/N] y
2012-09-23 05:40:43,554 DEBUG POST http://musicbrainz.org/ws/1/track/
2012-09-23 05:40:43,554 DEBUG POST-BODY: isrc=0cf10aa8-8c46-4043-a127-d1709e852c85+FITCR1000084&isrc=de07f5e3-78a3-4b9d-824f-464ef00db007+FITCR1000085&isrc=4304b6f1-bad8-4b2f-9252-93e5071d25d2+FITCR1000083
&isrc=dfc30454-4e8a-4795-94b1-5937d8b4e952+FITCR1000076&isrc=707da88c-07c0-44c8-87f7-d986fed7ddb6+FITCR1000080&isrc=2b4ed57e-5a00-40a3-8244-551f63e1e06a+FITCR1000078&isrc=d75f9240-dd4c-4ab8-8cc0-a3d3294ba9
a1+FITCR1000081&isrc=63fc0682-7da0-4635-82c1-c742aa2c3f64+FITCR1000077&isrc=ca5583be-6c13-4538-8e2a-891a0b1fb388+FITCR1000079&isrc=f4b46e7e-ca10-4db0-bc3e-9e2c75c9ec16+FITCR1000075&isrc=9c8fdb25-b457-4302-
a5e8-2171e189cd12+FITCR1000086&isrc=3957c6e4-b6fb-4728-8f60-07948d8a4cb7+FITCR1000082
2012-09-23 05:40:47,968 DEBUG POST failed: HTTP Error 400: Bad Request
ERROR: Invalid Request: HTTP Error 400: Bad Request
—

[ Show » ]

Kai Kasurinen added a comment - 23/Sep/12 02:53 AM adding FITCR1000075 is not possible anymore ("This is not a valid ISRC. If this code starts with "TC", it is a TuneCore ID, which should be put into the annotation instead.") — DiscID: DAeHAlVJ8pXTcZTbtK1_Be5cYLI- Tracks on Disc: 12 2012-09-23 05:40:29,674 DEBUG GET http://musicbrainz.org/ws/1/release/?type=xml&discid=DAeHAlVJ8pXTcZTbtK1_Be5cYLI- 2012-09-23 05:40:32,177 DEBUG GET http://musicbrainz.org/ws/1/release/eae6fd35-2c41-44d5-936d-c5509f4864b4?type=xml&inc=tracks+isrcs+artist+discs Artist: Maria Ylipää & Emma Salokoski Release: Omani uni found new ISRC for track 1: FITCR1000075 found new ISRC for track 2: FITCR1000076 found new ISRC for track 3: FITCR1000077 found new ISRC for track 4: FITCR1000078 found new ISRC for track 5: FITCR1000079 found new ISRC for track 6: FITCR1000080 found new ISRC for track 7: FITCR1000081 found new ISRC for track 8: FITCR1000082 found new ISRC for track 9: FITCR1000083 found new ISRC for track 10: FITCR1000084 found new ISRC for track 11: FITCR1000085 found new ISRC for track 12: FITCR1000086 Is this correct? [y/N] y 2012-09-23 05:40:43,554 DEBUG POST http://musicbrainz.org/ws/1/track/ 2012-09-23 05:40:43,554 DEBUG POST-BODY: isrc=0cf10aa8-8c46-4043-a127-d1709e852c85+FITCR1000084&isrc=de07f5e3-78a3-4b9d-824f-464ef00db007+FITCR1000085&isrc=4304b6f1-bad8-4b2f-9252-93e5071d25d2+FITCR1000083 &isrc=dfc30454-4e8a-4795-94b1-5937d8b4e952+FITCR1000076&isrc=707da88c-07c0-44c8-87f7-d986fed7ddb6+FITCR1000080&isrc=2b4ed57e-5a00-40a3-8244-551f63e1e06a+FITCR1000078&isrc=d75f9240-dd4c-4ab8-8cc0-a3d3294ba9 a1+FITCR1000081&isrc=63fc0682-7da0-4635-82c1-c742aa2c3f64+FITCR1000077&isrc=ca5583be-6c13-4538-8e2a-891a0b1fb388+FITCR1000079&isrc=f4b46e7e-ca10-4db0-bc3e-9e2c75c9ec16+FITCR1000075&isrc=9c8fdb25-b457-4302- a5e8-2171e189cd12+FITCR1000086&isrc=3957c6e4-b6fb-4728-8f60-07948d8a4cb7+FITCR1000082 2012-09-23 05:40:47,968 DEBUG POST failed: HTTP Error 400: Bad Request ERROR: Invalid Request: HTTP Error 400: Bad Request —

[ Permalink | « Hide ]

Ian McEwen added a comment - 23/Sep/12 03:02 AM

Ack, that's a good catch. I'll re-close this issue and open a new one, though – it's an easy patch, hopefully I can get some shippits before the end of the weekend