[#MBS-5119] work-recording vs. work-recordings add relationship pages inconsistent on labels around inputs - MusicBrainz JIRA

MusicBrainz Server

work-recording vs. work-recordings add relationship pages inconsistent on labels around inputs

Created: 09/Aug/12 09:32 AM Updated: 03/Sep/12 10:34 AM Resolved: 03/Sep/12 10:34 AM

Component/s:

Edit system, Templates, User interface

Affects Version/s:

None

Fix Version/s:

Bug fixes, 2012-09-03

Description

« Hide

In work-recording (without s) add relationship edit page, the check-boxes have labels around them (which allows clicking on text to check) on cover, live, partial, instrumental attributes for instance.
<label><input type="checkbox"></label>

In work-recordings (with s) add relationship edit page, there is no label.
<input type="checkbox">
Could they be added there too ?

() Notice that feeding the select in URL parameter doesn't work

Sort Order:

[ Permalink | « Hide ]

Ian McEwen added a comment - 09/Aug/12 10:05 AM

Seeding/feeding the select parameter is ~~MBS-4543~~ – the rest, however, I'll look into, shouldn't be a hard fix

[ Permalink | « Hide ]

Ian McEwen added a comment - 09/Aug/12 10:06 AM

Though I'll note that the template this affects will be removed by bitmap's work on the relationship editor, so it may be a short-lived fix.

Ian McEwen made changes - 09/Aug/12 10:12 AM

Field	Original Value	New Value
Assignee		Ian McEwen [ ianmcorvidae ]

Ian McEwen made changes - 09/Aug/12 10:16 AM

Status

Open [ 1 ]

Review Submitted [ 5 ]

[ Permalink | « Hide ]

patate12 added a comment - 09/Aug/12 01:58 PM

Will the future template be using those labels ?

[ Permalink | « Hide ]

patate12 added a comment - 09/Aug/12 02:03 PM

Hey thanks for fixing this by the way !

[ Permalink | « Hide ]

Ian McEwen added a comment - 09/Aug/12 08:01 PM

The future template operates in a different way; I'd recommend trying out the relationship editor on bitmap.mbsandbox.org, where as far as I know it should still be running.

[ Permalink | « Hide ]

patate12 added a comment - 10/Aug/12 07:18 AM

Thanks very much for this very ticket caring of.

Off topic (bitmap) :

For the record on bitmap's my tests w-r (label ok, feeding ng) w-rs says « edit not found » although it's not looking for an edit.
Perhaps you can tell me where is his work's ticket so I can move this off topic part over there ?

Ian McEwen made changes - 14/Aug/12 03:01 AM

Fix Version/s

Bug fixes, 2012-09-03 [ 10151 ]

Oliver Charles made changes - 20/Aug/12 01:42 PM

Status

Review Submitted [ 5 ]

In Beta Testing [ 10002 ]

Oliver Charles made changes - 03/Sep/12 10:34 AM

Status	In Beta Testing [ 10002 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]