[#MBS-5066] IPI fields are not validated properly - MusicBrainz JIRA

MusicBrainz Server

IPI fields are not validated properly

Created: 31/Jul/12 10:20 PM Updated: 17/Sep/12 10:29 AM Resolved: 17/Sep/12 10:29 AM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

2012-09-17

Issue Links:

Duplicate

This issue is duplicated by:

~~MBS-5174~~ Edit Artist with an IPI code will mangle the IPI code

Description

« Hide

http://beta.musicbrainz.org/edit/18564484 Here I edited the disambiguation comment and pressed enter. I didn't even get as far down as the IPI field. When I submitted it, it changed the IPI.

Editing the artist again shows "MusicBrainz::Server::Entity::ArtistIPI=HASH(0x11c9a410)" in the IPI field (see ~~MBS-5050~~). I'm guessing somehow turned that into an IPI instead of giving an error.

Sort Order:

[ Permalink | « Hide ]

Anonymous MusicBrainz User added a comment - 03/Aug/12 01:46 AM - edited

Same problem in released version (in use), not only in beta: see http://musicbrainz.org/edit/18590114.

I don't know perl... might be hash of hash problem? ("Item 4" at http://curtisquarterly.blogspot.it/2005/05/perl-tutorial.html)

[ Permalink | « Hide ]

Oliver Charles added a comment - 15/Aug/12 04:01 PM

Now that ~~MBS-5050~~ is being resolved, does this resolve this ticket too?

[ Permalink | « Hide ]

Ian McEwen added a comment - 15/Aug/12 11:00 PM

I think that it's cleaning non-numeric characters silently, which resulted in the bad edits; it should give a validation error instead – it's no different, presumably, if someone just enters in "MusicBrainz::Server::Entity::ArtistIPI=HASH(0x11c9a410)" on their own, or any other string with non-numeric characters. That bug just made this one more obvious

nikki made changes - 18/Aug/12 08:18 PM

Field	Original Value	New Value
Link		This issue is duplicated by ~~MBS-5174~~ [ ~~MBS-5174~~ ]

[ Permalink | « Hide ]

Ross Collins added a comment - 18/Aug/12 08:36 PM

Can someone easily do a search to find out the extent of the damage caused by this bug and possibly repair it all? I've had a quick search and found some edits that appear to be affected by it:

http://musicbrainz.org/edit/18732051
http://musicbrainz.org/edit/18731945
http://musicbrainz.org/edit/18730267
http://musicbrainz.org/edit/18725639

[ Permalink | « Hide ]

Anonymous MusicBrainz User added a comment - 19/Aug/12 05:43 PM - edited

With http://musicbrainz.org/search?query=ipi%3A000000*&type=artist&limit=25&method=advanced we can found some artists having probably an altered IPI code like 000000nnnnn.

I edited most of this entries (waiting for a vote).

Any suggest?

[ Permalink | « Hide ]

Anonymous MusicBrainz User added a comment - 26/Aug/12 05:44 PM

The bug seems to be fixed. I have not tried to edit an artist, but the Edit Artist page does not show anymore "MusicBrainz::Server::Entity::ArtistIPI=HASH(0x... ".

See some examples:
http://musicbrainz.org/artist/99571b90-b6b9-476c-871c-75249ea14f07/edit
http://musicbrainz.org/artist/469030d3-6aac-49e4-948d-85d525de2eb1/edit
http://musicbrainz.org/artist/1c01cf84-07c7-408a-b5a8-7dae0b1312fc/edit

[ Permalink | « Hide ]

nikki added a comment - 26/Aug/12 06:29 PM

~~MBS-5050~~ is fixed, so the form doesn't display stuff like "MusicBrainz::Server::Entity::ArtistIPI=HASH(0x11c9a410)" now, but the underlying problem is still there - it's still not validating the IPI field, so you can still paste in "MusicBrainz::Server::Entity::ArtistIPI=HASH(0x11c9a410)" and it'll still accept it. I've updated the summary to reflect that.

nikki made changes - 26/Aug/12 06:29 PM

Summary

Submitting an artist edit changed the IPI

IPI fields are not validated properly

Oliver Charles made changes - 29/Aug/12 11:57 AM

Status

Open [ 1 ]

Review Submitted [ 5 ]

Oliver Charles made changes - 29/Aug/12 11:57 AM

Assignee

Oliver Charles [ acid2 ]

[ Permalink | « Hide ]

Oliver Charles added a comment - 29/Aug/12 11:57 AM

In review at http://codereview.musicbrainz.org/r/2221/

Oliver Charles made changes - 03/Sep/12 04:26 PM

Status

Review Submitted [ 5 ]

In Beta Testing [ 10002 ]

Oliver Charles made changes - 03/Sep/12 04:26 PM

Fix Version/s

2012-09-17 [ 10152 ]

Oliver Charles made changes - 17/Sep/12 10:29 AM

Status	In Beta Testing [ 10002 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]