[#MBS-5043] Edit search forgets "low" data quality selection - MusicBrainz JIRA

MusicBrainz Server

Edit search forgets "low" data quality selection

Created: 23/Jul/12 06:36 AM Updated: 17/Sep/12 10:29 AM Resolved: 17/Sep/12 10:29 AM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

2012-09-17

Description

« Hide

http://beta.musicbrainz.org/search/edits?auto_edit_filter=&order=desc&negation=0&combinator=and&conditions.0.field=release_quality&conditions.0.operator=%3D&conditions.0.args=0&conditions.1.field=status&conditions.1.operator=%3D&conditions.1.args=1&field=Please+choose+a+condition

If you select "low" and search, the results page that loads does not have "low" selected. All the others seem to work fine.

Sort Order:

[ Permalink | « Hide ]

Ian McEwen added a comment - 23/Jul/12 01:21 PM

I think this is because low data quality == 0 – the line that sets the selected thing has [% 'selected="selected"' IF field_contents.find_argument(item.0) %] which may not be the best way to do that

Ian McEwen made changes - 05/Sep/12 08:15 PM

Field	Original Value	New Value
Assignee		Ian McEwen [ ianmcorvidae ]

[ Permalink | « Hide ]

Ian McEwen added a comment - 05/Sep/12 08:20 PM

http://codereview.musicbrainz.org/r/2263/

Ian McEwen made changes - 05/Sep/12 08:21 PM

Status

Open [ 1 ]

Review Submitted [ 5 ]

Oliver Charles made changes - 07/Sep/12 11:17 AM

Status

Review Submitted [ 5 ]

In Beta Testing [ 10002 ]

Oliver Charles made changes - 07/Sep/12 11:17 AM

Fix Version/s

2012-09-17 [ 10152 ]

Oliver Charles made changes - 17/Sep/12 10:29 AM

Status	In Beta Testing [ 10002 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]