Issue Details (XML | Word | Printable)

Key: MBS-5038
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: Ian McEwen
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

favicon.ico includes both the 16x16 NGS image (which we use) and a larger 32x32 image left over from Mason

Created: 22/Jul/12 12:43 AM   Updated: 06/Aug/12 09:58 AM   Resolved: 06/Aug/12 09:58 AM
Component/s: None
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-08-06

File Attachments: 1. Text File favicon-hexdump.txt (10 kB) 22/Jul/12 12:43 AM - Ian McEwen



 Description  « Hide

Annotated hexdump of the file attached, this took us a bit to decipher on IRC

Seems likely we should just use one or the other; I'd vote the smaller (but much cleaner) 16x16 image.



Ian McEwen made changes - 22/Jul/12 12:50 AM
Field Original Value New Value
Assignee Ian McEwen [ ianmcorvidae ]
Ian McEwen made changes - 22/Jul/12 01:07 AM
Status Open [ 1 ] Review Submitted [ 5 ]
Oliver Charles added a comment - 23/Jul/12 07:59 AM

I see a lot of talk (http://chatlogs.musicbrainz.org/musicbrainz-devel/2012/2012-07/2012-07-22.html) about confusion between different images, but not what the actual problem is. The .ico format exists to store multiple sizes of an image so that whatever is using them can display the most appropriate size. It'd be nice if all resolutions were actually of the same image, so is that the problem that's trying to be solved?


Ian McEwen added a comment - 23/Jul/12 11:33 AM

The problem as I see it is primarily that we aren't actually using the larger image – none of the browsers we checked, as I recall, actually used it as a favicon. We'd see it when we opened it up manually in the browser (i.e., went to the URL of the favicon itself), or if we used some programs that (apparently) preferenced the larger image, but not otherwise. Hence removing the larger 32x32 image – it's barely used, outdated, and makes working with the file confusing.


Oliver Charles made changes - 24/Jul/12 09:56 AM
Status Review Submitted [ 5 ] In Beta Testing [ 10002 ]
Oliver Charles made changes - 24/Jul/12 09:57 AM
Fix Version/s Bug fixes, 2012-08-06 [ 10149 ]
Oliver Charles made changes - 06/Aug/12 09:58 AM
Status In Beta Testing [ 10002 ] Closed [ 6 ]
Resolution Fixed [ 1 ]