[#MBS-4994] MB should trim whitespace from catalog numbers - MusicBrainz JIRA

MusicBrainz Server

MB should trim whitespace from catalog numbers

Created: 09/Jul/12 01:24 PM Updated: 06/Aug/12 10:17 AM Resolved: 06/Aug/12 10:17 AM

Component/s:

Edit system

Affects Version/s:

None

Fix Version/s:

Bug fixes, 2012-08-20

Description

« Hide

Currently, MB allows catalog numbers to have trailing (and leading?) spaces. It shouldn't.

Sort Order:

[ Permalink | « Hide ]

nikki added a comment - 09/Jul/12 01:56 PM

Does it? It used to be possible but that was fixed and I can't reproduce it any more.

[ Permalink | « Hide ]

Alex Mauer added a comment - 09/Jul/12 03:02 PM

It does. See this edit, which corrects one of them (found by accident)

http://musicbrainz.org/edit/18292136

[ Permalink | « Hide ]

nikki added a comment - 09/Jul/12 03:38 PM

But that's cleaning it up, not adding it. The edit to add it looks to be http://beta.musicbrainz.org/edit/16558587 from months ago, definitely from before the bug was fixed.

Checking the DB, I don't see any leading or trailing spaces in catnos added since April.

[ Permalink | « Hide ]

Alex Mauer added a comment - 09/Jul/12 03:46 PM

Agreed — but the system still allows them to remain, which is what I hoped to be resolved for this ticket.

[ Permalink | « Hide ]

nikki added a comment - 25/Jul/12 04:33 AM

I've cleaned up the ones which remained manually and the server doesn't let you enter new ones, so there's nothing to do here now.

[ Permalink | « Hide ]

Oliver Charles added a comment - 25/Jul/12 07:39 AM

Actually, there is a bit more to do - enforce this at the database level. Now that you've cleaned it all up, that check can be trivially added.