[#MBS-4950] Internal server error when cancelling a recording merge instead of submitting - MusicBrainz JIRA

MusicBrainz Server

Internal server error when cancelling a recording merge instead of submitting

Created: 30/Jun/12 02:03 AM Updated: 17/Sep/12 10:29 AM Resolved: 17/Sep/12 10:29 AM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

2012-09-17

Issue Links:

Relates

This issue is related to:

MBS-2250 Cancelling a merge should redirect more intelligently

Description

« Hide

To reproduce:
1. Select a couple of recordings for merging, e.g. both recordings on http://beta.musicbrainz.org/isrc/ARF100900390 and you'll end up on http://beta.musicbrainz.org/recording/merge
2. Click "cancel".

Error: 

Caught exception in MusicBrainz::Server::Controller::Recording->merge "Can't use an undefined value as an ARRAY reference at lib/MusicBrainz/Server/Controller/Recording.pm line 186."


Stack trace:
line 186 MusicBrainz::Server::Controller::Recording
line 77 MusicBrainz::Server::Controller::Role::Merge
line 306 MusicBrainz::Server
line 306 MusicBrainz::Server
line 306 MusicBrainz::Server
line 270 MusicBrainz::Server


Request data: 
$VAR1 = {
          'query_parameters' => {},
          'body_parameters' => {}
        };
            

URL: http://beta.musicbrainz.org/recording/merge

Also confirmed that it's not just beta.

Sort Order:

[ Permalink | « Hide ]

Ian McEwen added a comment - 08/Jul/12 04:56 AM

More info: this is in the "before '_merge_confirm'" block of Controller::Recording, when it tries to

$c->model('ISRC')->load_for_recordings(@recordings);

, where @recordings is

@{ $c->stash->{to_merge} };

. I'm guessing that the merge is cancelling but then redirecting to itself and erroring because it successfully cancelled, or something like that.

More investigation later, perhaps.

[ Permalink | « Hide ]

Ian McEwen added a comment - 09/Jul/12 09:58 PM - edited

Yeah, in _merge_cancel in Role::Merge it redirects to $c->req->referer || $c->uri_for('/'). What should this redirect to instead?

[ Permalink | « Hide ]

Ian McEwen added a comment - 14/Aug/12 03:02 AM

Presuming ocharles responds to my comments on the codereview, this should end up in the 09-03 release.