Issue Details (XML | Word | Printable)

Key: MBS-4949
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Lukáš Lalinský
Reporter: Lukáš Lalinský
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Facebook URLs not properly decoded

Created: 29/Jun/12 01:28 PM   Updated: 16/Jul/12 12:09 PM   Resolved: 16/Jul/12 12:09 PM
Component/s: User interface
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-07-23


 Description  « Hide

See for example http://musicbrainz.org/artist/266d1014-7175-417e-9d39-554b7465073e

Sorry, I don't have a dev VM set up, so I can't commit the fix, but here is the diff:

diff --git a/lib/MusicBrainz/Server/Entity/URL/Facebook.pm b/lib/MusicBrainz/Server/Entity/URL/Facebook.pm
index 4f2b52a..af3c23b 100644
--- a/lib/MusicBrainz/Server/Entity/URL/Facebook.pm
+++ b/lib/MusicBrainz/Server/Entity/URL/Facebook.pm
@@ -1,6 +1,7 @@
 package MusicBrainz::Server::Entity::URL::Facebook;
 
 use Moose;
+use MusicBrainz::Server::Filters;
 
 extends 'MusicBrainz::Server::Entity::URL';
 with 'MusicBrainz::Server::Entity::URL::Sidebar';
@@ -9,7 +10,7 @@ sub sidebar_name {
     my $self = shift;
 
     if ($self->url =~ m{^https?://(?:www.)?facebook.com/(?:pages/)?([^/]+)(?:/[^/]+)?/?$}i) {
-        return $1;
+        return MusicBrainz::Server::Filters::uri_decode($1);
     } else {
         return "Facebook";
     }


Sort Order: Ascending order - Click to sort in descending order
Oliver Charles added a comment - 16/Jul/12 12:09 PM

I've merged this straight to master, it is also on beta/test.