[#MBS-4929] Some fields on user's "Open edits" page are duplicating while merging works - MusicBrainz JIRA

MusicBrainz Server

Some fields on user's "Open edits" page are duplicating while merging works

Created: 25/Jun/12 04:11 PM Updated: 16/Oct/12 07:55 PM Resolved: 16/Oct/12 07:55 PM

Component/s:

Edit system

Affects Version/s:

None

Fix Version/s:

Schema change, 2012-10-15

File Attachments:

None

Image Attachments:

1. Screenshot_2012-06-25_195156_cropped.png
(66 kB)

Description

« Hide

During merging of works, there is duplicate items in the "Into/Target" field on user's "Open Edits" page, meanwhile on separate edits pages everything looks normal. See attached screenshot and edits pages: http://musicbrainz.org/edit/18115507 and http://musicbrainz.org/edit/18115605 The target work also looks fine (no duplicate information): http://musicbrainz.org/work/d6c394de-6bcb-3650-b018-f16b3842bc73

Sort Order:

[ Permalink | « Hide ]

patate12 added a comment - 26/Jun/12 08:25 AM

What's your browser ? I don't see those duplicate composer stuff (in my Opera 12).

[ Permalink | « Hide ]

Oliver Charles added a comment - 26/Jun/12 09:28 AM

This is not browser specific, and this bug is confirmed. No need for further discussion

[ Permalink | « Hide ]

Oleg Kuznetsov added a comment - 26/Jun/12 12:51 PM

My user page: http://musicbrainz.org/user/X-Pilot/edits/open Currently, the edits are in the beginning of the page

[ Permalink | « Hide ]

Ian McEwen added a comment - 05/Sep/12 09:29 PM

Digging into this issue a bit; looks like what's happening is our code to load writers and recording-linked artists gets run for each work merge edit on the page – meaning, in that case, since there's two merge edits into the same work, it runs twice. The code also isn't apparently smart enough to detect if those artists are already loaded, so it just ends up loading them again.

Seeing what I can do about it now...

Ian McEwen made changes - 05/Sep/12 09:34 PM

Field	Original Value	New Value
Assignee		Ian McEwen [ ianmcorvidae ]

[ Permalink | « Hide ]

Ian McEwen added a comment - 05/Sep/12 09:53 PM

http://codereview.musicbrainz.org/r/2264/

Ian McEwen made changes - 05/Sep/12 09:53 PM

Status

Open [ 1 ]

Review Submitted [ 5 ]

Oliver Charles made changes - 10/Sep/12 10:41 AM

Fix Version/s

2012-10-01 [ 10153 ]

[ Permalink | « Hide ]

Oliver Charles added a comment - 25/Sep/12 11:44 AM

The merge window for 2012-10-01 is now closed, so this will have to wait until 2012-10-15.

Oliver Charles made changes - 25/Sep/12 11:44 AM

Fix Version/s		Schema change, 2012-10-15 [ 10118 ]
Fix Version/s	2012-10-01 [ 10153 ]

Oliver Charles made changes - 01/Oct/12 03:25 PM

Status

Review Submitted [ 5 ]

In Beta Testing [ 10002 ]

Ian McEwen made changes - 07/Oct/12 10:37 PM

Component/s

Edit system [ 10001 ]

Oliver Charles made changes - 16/Oct/12 07:55 PM

Status	In Beta Testing [ 10002 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]