Issue Details (XML | Word | Printable)

Key: MBS-4916
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: Ian McEwen
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Isolate i18n locale-switching

Created: 21/Jun/12 09:21 AM   Updated: 23/Jul/12 05:24 AM   Resolved: 23/Jul/12 05:24 AM
Component/s: Internationalization
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-07-23


 Description  « Hide

Several related issues:

1.) web_set_locale should probably set only LC_MESSAGES, if we can get away with it
2.) _set_language should be called once per request, not once per translated string
3.) the locale should be reset to (probably) en_US after translation is done (hopefully, after templates are rendered will do), so we don't mess with any other perl code that might be (probably unintentionally) locale-dependent, such as http://pastie.org/4125293 in catalyst (the %f in sprintf uses LC_NUMERIC, breaking the numeric usage of the variable later).



Sort Order: Ascending order - Click to sort in descending order
Ian McEwen made changes - 03/Jul/12 09:22 PM
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Ian McEwen made changes - 03/Jul/12 09:28 PM
Status In Progress [ 3 ] Review Submitted [ 5 ]
Oliver Charles made changes - 09/Jul/12 10:48 AM
Fix Version/s Bug fixes, 2012-07-24 [ 10148 ]
Oliver Charles made changes - 10/Jul/12 06:25 AM
Status Review Submitted [ 5 ] In Beta Testing [ 10002 ]
Oliver Charles made changes - 23/Jul/12 05:24 AM
Status In Beta Testing [ 10002 ] Closed [ 6 ]
Resolution Fixed [ 1 ]