[#MBS-4893] "No edit notes have been added." should not be on edit listing pages. - MusicBrainz JIRA

MusicBrainz Server

"No edit notes have been added." should not be on edit listing pages.

Created: 14/Jun/12 12:10 AM Updated: 14/Jun/12 09:50 AM Resolved: 14/Jun/12 09:41 AM

Component/s:

Edit system

Affects Version/s:

None

Fix Version/s:

Bug fixes, 2012-06-25

Issue Links:

Relates

This issue is related to:

MBS-4070 Make the voting page more compact

Description

« Hide

Because template toolkit's DEFAULT kicks in whenever the value is falsy, passing '0' doesn't work, and it always gets set to 1. Thus, we have the "No edit notes" warning even on the long vote list, rather than just on the details page, like we're supposed to.

Sort Order:

Ian McEwen made changes - 14/Jun/12 12:10 AM

Field	Original Value	New Value
Link		This issue is related to MBS-4070 [ MBS-4070 ]

Ian McEwen made changes - 14/Jun/12 12:11 AM

Assignee

Ian McEwen [ ianmcorvidae ]

Ian McEwen made changes - 14/Jun/12 12:16 AM

Status

Open [ 1 ]

Review Submitted [ 5 ]

Oliver Charles made changes - 14/Jun/12 09:41 AM

Status	Review Submitted [ 5 ]	Closed [ 6 ]
Fix Version/s		Bug fixes, 2012-06-25 [ 10146 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Oliver Charles added a comment - 14/Jun/12 09:42 AM

Shipped, but could you change the title of this something that's more 'user friendly' for the release notes?

[ Permalink | « Hide ]

Ian McEwen added a comment - 14/Jun/12 09:50 AM

Changed the name to be a bit more friendly

Ian McEwen made changes - 14/Jun/12 09:50 AM

Summary	Vote list 'verbose' option doesn't work	"No edit notes have been added." should not be on edit listing pages.
Description	Because template toolkit's DEFAULT kicks in whenever the value is falsy, passing '0' doesn't work, and it always gets set to 1. This is why we have the "No edit notes" warning even on the long vote list.	Because template toolkit's DEFAULT kicks in whenever the value is falsy, passing '0' doesn't work, and it always gets set to 1. Thus, we have the "No edit notes" warning even on the long vote list, rather than just on the details page, like we're supposed to.