Issue Details (XML | Word | Printable)

Key: MBS-4876
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: Ian McEwen
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Allow contexts to be used for translations in the mb_server and statistics domains.

Created: 11/Jun/12 06:33 PM   Updated: 28/Sep/12 10:49 AM   Resolved: 23/Jul/12 05:24 AM
Component/s: Internationalization
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-07-23


 Description  « Hide

There are some strings where this would be useful.

Tasks:

  • make sure the TT plugins provide lp()
  • make sure the extraction scripts recognize lp()
  • change things to use lp() that should be contextualized (some examples in comments, hopefully)


Sort Order: Ascending order - Click to sort in descending order
Ian McEwen added a comment - 27/Jun/12 10:11 PM

Ignoring task #3 for now because I haven't gotten any feedback on that. Will need to make a new issue, or several, for those fixes.


Ian McEwen added a comment - 27/Jun/12 10:19 PM

Oliver Charles added a comment - 09/Jul/12 12:48 PM

ianmcorvidae/mbs-4876-template-i18n-context merged into beta.


Luca Salini added a comment - 16/Aug/12 06:31 PM

I'm reporting an example of a string that should be contextualized.
In the mb_server translation, the string Accepted currently has two occurrences: one in ../root/user/profile.tt:148, where it refers to accepted edits, the other in ../lib/MusicBrainz/Server/Entity/AutoEditorElection.pm:101, where it refers to an accepted (i.e. elected) auto-editor.
Those different occurrences would need two different translations in Italian and in most Romance languages.


Mihkel Tõnnov added a comment - 24/Aug/12 10:27 PM

A few more examples, also reported here: http://lists.musicbrainz.org/pipermail/musicbrainz-i18n/2012-August/000162.html

For Estonian translation, I'd like the following to happen:
a) Anything from #: ../lib/MusicBrainz/Server/Edit//.pm should have its
own string
b) These should be split into 1) button/menu command 2) window/section/tab
title:
"Add Cover Art"
"Add Release"
"Edit"
"Search"
"Log In"
"Browse"
c) "Status" should be split into 1) the string for release status 2) the
string for edit status


Ian McEwen added a comment - 21/Sep/12 12:15 AM - edited

Other things from v6lur's emails:

"anything in the timeline graphs which appears in contexts à la "123456 Edits" should be a separate string to be correctly translated into estonian" (due to it being correctly lowercase in those languages)

"from Estonian point of view, "Name" (and "Name:") should be split based on whether it applies to works/recordings/tracks/releases/RGs or artists/label, since the first lot should have a 'title' in Estonian, not 'name'"

"the verb "Tag" (on the button) should be split from the noun "Tag" (e.g. in the search dropdown near the top-right corner)"

I'm not sure about the correct approach to the first/second – probably for the first it should be "{num} Edits" or such instead; for the second I wonder if it shouldn't just be title in english too.

Third is obviously correct. (edit: apparently I can't even type English right)


Ian McEwen added a comment - 21/Sep/12 12:21 AM

For Accepted vs. Accepted, I've added a context to the first ("edit descriptor") but not the latter, since that's currently using N_l and a passthrough, and is thus more complicated. They're still split, but ultimately I'll want to add N_lp and change them to be passed through lp().


Ian McEwen added a comment - 21/Sep/12 05:52 AM

http://codereview.musicbrainz.org/r/2314/ includes some (but not all) of the things from comments – getting it up so it makes the next release, and will work on more in another branch.


Mihkel Tõnnov added a comment - 21/Sep/12 02:50 PM

I'm not sure about the correct approach to the first/second - probably for the first it should be "{num} Edits" or such instead; ...

Yes, that'd be nice

... for the second I wonder if it shouldn't just be title in english too.

Now that you mention it, "album title" does seem a bit more 'comfortable' in English...

Oh, and some more strings I'd like to be split:
"Add Release", "Add Work", "Add Label", "Add Standalone Recording" – split menu command and window/section/edit title.


Mihkel Tõnnov added a comment - 21/Sep/12 04:31 PM - edited

...and "Guess Case", and "Add Cover Art" too


Ian McEwen added a comment - 28/Sep/12 10:49 AM

If you have further strings to contextualize, please add them to MBS-5380, which I've created for this