Issue Details (XML | Word | Printable)

Key: MBS-4872
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Alastair Porter
Reporter: Alastair Porter
Votes: 1
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Can't directly add a release to a collection if no collections exist

Created: 11/Jun/12 01:34 PM   Updated: 17/Sep/12 10:29 AM   Resolved: 17/Sep/12 10:29 AM
Component/s: Collections
Affects Version/s: Bug fixes, 2012-05-28
Fix Version/s: 2012-09-17

Issue Links:
Depends
 


 Description  « Hide

If you have no collections, the options available are :

  • You have no collections!
  • Create a new collection
  • Found in 0 user collections

You can't create a new collection and add the release to it in a single move, instead you need to make collection, get redirected to collection page, go back to release page, add.



Sort Order: Ascending order - Click to sort in descending order
nikki added a comment - 30/Jun/12 02:23 AM

Reopening since this was changed anonymously. Also why the hell is it so hard to prevent people from changing statuses anonymously in JIRA?


Alastair Porter added a comment - 03/Aug/12 08:43 PM

The link for adding a release to a collection currently looks like this:
http://musicbrainz.music.mcgill.ca/collection/296c0d92-4eed-4f45-a46c-d1e3c4c4118f/own_collection/add?release=428732

Are we happy using database ids to refer to releases or should we be replacing it with a uuid? My plan was to have a similar url structure for when collections are created:
http://musicbrainz.music.mcgill.ca/collection/create?release=uuid


Ian McEwen added a comment - 03/Aug/12 08:53 PM

For a one-time endpoint like this, I'm not sure it matters if we use rowids rather than MBIDs – the MBIDs are beneficial for storing more than for immediate things. I don't know how collections at present deal with merges, admittedly, since the schema uses rowids – I imagine it cascades them or updates those entries somehow.

Using an MBID does make links have a longer lifetime – so I guess the question is whether we think many people from external sites are going to be linking add-to-collection URLs (I'd guess not, in which case, rowid seems fine).


Alastair Porter added a comment - 03/Aug/12 09:00 PM

Right. From what I've found, merges are dealt with, because the actual links in the database tables use uuids, and there's a bunch of merge functionality. Good point about the difference between links and permanent entities. I'll stick with rowid for now


Ian McEwen added a comment - 03/Aug/12 09:44 PM

They don't use UUIDs, actually: https://github.com/metabrainz/musicbrainz-server/blob/master/admin/sql/CreateTables.sql#L890 but I'm guessing the way merges are done automatically updates those rows.


Oliver Charles added a comment - 06/Aug/12 09:39 AM

I would prefer we use an MBID. We should really be using MBIDs wherever we can, row IDs are an internal thing.