Some of URLs in Wikipedia ends on exclamation mark (if article's subject demand it), but looks like URL parser thinks, that it is a start of user's commentary
Changing this will just break other URLs where the exclamation mark is not part of the URL. I'd rather just see MBS-2542 implemented.
Is it hard to escape exclamation marks with "%21" when user submit the form? MBS-2542 would be nice too.
Edit notes are stored as text, not HTML, and I don't want to change that. There are 88 URLs in edit notes (according to my rough search) that have a ! character at the end of them, and not a single one of them is intended as other punctuation (that is, all URLs that end with ! actually have that character as part of the URL).
select text From edit_note where text ~ E'http[^\s\r\n\t ]+! ';
I am willing to change our URL catching regular expression to handle this case.
MBS-2542 doesn't ask for storing HTML, it asks for a syntax the server turns into HTML, which is exactly what our current "URL catching regular expression" is doing, but poorly in cases like this.
Here's one you must have overlooked then: http://musicbrainz.org/edit/2863790
Here's another: http://musicbrainz.org/edit/3999101
@Ian: I don't say MBS-2542 did ask for that, I said I don't want to store HTML in edit notes which Oleg suggested by asking for escaping ! to %21 on form submission.
@nikki: As I said, rough search - but I don't think 2 counter examples is sufficient to say that the current behavior is correct. The majority of these URLs are Wikipedia ones and having a working source link seems more important. Also, I'm used to removing cruft from URLs I click from IRC and the like (removing commas from URLs), so I am more used to removing text from broken URLs in my browser, than adding extra text.
But if we're going to run around in circles on this then I will just close it as wont fix and we can focus on MBS-2542.