Issue Details (XML | Word | Printable)

Key: MBS-4841
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Nicolás Tamargo
Reporter: MeinDummy
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

update to new Jamendo URL scheme

Created: 06/Jun/12 12:08 PM   Updated: 14/Jun/12 11:12 AM   Resolved: 14/Jun/12 11:12 AM
Component/s: JavaScript
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-06-25


 Description  « Hide

Jamendo has recently changed their URL scheme such that the Java script that removes the language part does not work anymore.

Example:
http://www.jamendo.com/en/list/a81403/the-cabinet-ep should be converted into
http://www.jamendo.com/list/a81403/the-cabinet-ep

Please update.



Sort Order: Ascending order - Click to sort in descending order
Nicolás Tamargo added a comment - 06/Jun/12 01:08 PM

Does this break the links, or just stops them from being cleaned up? (if the latter, I wouldn't call it a bug, although I'll try to look into it for next release)


MeinDummy added a comment - 06/Jun/12 01:25 PM

No, it doesn't break the links but it will force the pages to display in English instead of in the user-selected language.


Nicolás Tamargo added a comment - 06/Jun/12 01:29 PM

Sure, but those can be all fixed via a bot or a script later. Anyway, will look into it.


MeinDummy added a comment - 06/Jun/12 02:30 PM

Should be a no-brainer anyway ;o)


Nicolás Tamargo added a comment - 06/Jun/12 03:55 PM - edited

Ok, that mini-thing has been changed. Not sure if the stuff after the ID should be removed, but it seems it wasn't touched before. Opinion?

Edit: the link does work without it, but it redirects to the full URL anyway - which is why I am wondering what's better.


MeinDummy added a comment - 06/Jun/12 04:21 PM

Ahh, I haven't realized that this part can also be omitted.

However, before the URL scheme change this stuff wasn't there. URLs were like http://www.jamendo.com/en/album/81403 (which BTW still works).
I just checked a recently downloaded MP3 file and they still have that old URL in the WWWAUDIOSOURCE tags.

Not sure if artists can or will ever change release titles but if they do then only the URL without the title is stable. Therefore my +0.1 for removing it.