Issue Details (XML | Word | Printable)

Key: MBS-4828
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: nikki
Votes: 2
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Work language not returned in release ws requests

Created: 03/Jun/12 05:39 PM   Updated: 20/Aug/12 09:51 AM   Resolved: 20/Aug/12 09:51 AM
Component/s: Web service
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-08-20

Issue Links:
Depends
 
Relates


 Description  « Hide

Bitmap's relationships script does a request like http://musicbrainz.org/ws/2/release/ab156a4c-060e-366c-8e68-3c9dc94e51b4?inc=recordings+recording-level-rels+work-level-rels+label-rels+url-rels+work-rels

This returns (or at least used to, see MBS-4792) nearly all the information about the work - the name, disambiguation comment, ISWCs and relationships, but not the language.



Sort Order: Ascending order - Click to sort in descending order
Johannes Weißl added a comment - 21/Jun/12 01:17 AM - edited

If I get it right no property of works is returned (also not the type), just the relations. E.g. this is the request Picard makes:
http://musicbrainz.org/ws/2/release/0eaeb5bf-e766-424c-b0e9-d27798d722bd?inc=release-groups%2Bmedia%2Brecordings%2Bpuids%2Bartist-credits%2Bartists%2Baliases%2Blabels%2Bisrcs%2Bartist-rels%2Brelease-rels%2Burl-rels%2Brecording-rels%2Bwork-rels%2Brecording-level-rels%2Bwork-level-rels

And this is the XML request for the work of the first track:
http://musicbrainz.org/ws/2/work/36c09693-86e9-4d25-9d82-c1b2e0057582

What would be needed in my opinion is a "works" include parameter for releases, e.g.:
http://musicbrainz.org/ws/2/release/0eaeb5bf-e766-424c-b0e9-d27798d722bd?inc=works

This would be very useful, because PICARD-242 could be implemented then.

EDIT: The only property returned is the title.


nikki added a comment - 21/Jun/12 07:09 AM

Hm. I'm not sure I agree. We used to return all the information about the work except for the type. I don't know why that was the case and since I never use that field, I never even noticed. Since we are (or rather, given that we broke it, should be) already returning almost everything about the work (and would have to continue doing so for backwards compatibility), it seems overkill to me to add a new option just to add the type and language.


Oliver Charles added a comment - 21/Jun/12 09:30 AM

We return all information inside the work table, without joining any other tables. I'm not really sure what to do here, the options are:

  • Keep relationships to be very lightweight, and not join other tables
  • Join other tables to reduce extra queries

Johannes Weißl added a comment - 22/Jun/12 06:09 PM

I agree both options have pros and cons... so why not control it with `inc`-options?


Oliver Charles added a comment - 06/Aug/12 07:54 PM

A decision has been reached, work language will always be present.


Oliver Charles added a comment - 07/Aug/12 02:05 PM