[#MBS-4793] Preferences displays wrong date/time format - MusicBrainz JIRA

MusicBrainz Server

Preferences displays wrong date/time format

Created: 28/May/12 07:46 PM Updated: 23/Jul/12 05:24 AM Resolved: 23/Jul/12 05:24 AM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

Bug fixes, 2012-07-23

Description

« Hide

Simon selected the "28.05.2012 21:41" format and saved the preferences. When he goes back to the page, it shows "2012-05-28 21:41 CEST" as the selected format.

Pages use the format he selected, so it seems it does save the preference correctly, it just doesn't select the correct one when displaying the preferences.

Sort Order:

[ Permalink | « Hide ]

Ian McEwen added a comment - 07/Jul/12 06:50 AM

Looks like this can be fixed by adding some handling to root/account/preferences.tt to set @selected based on form.field('datetime_format').value or so.

Ian McEwen made changes - 07/Jul/12 06:55 AM

Field	Original Value	New Value
Assignee		Ian McEwen [ ianmcorvidae ]

Ian McEwen made changes - 07/Jul/12 06:56 AM

Status

Open [ 1 ]

In Progress [ 3 ]

[ Permalink | « Hide ]

Ian McEwen added a comment - 07/Jul/12 06:56 AM

note to self: branch mbs-4793-datetime-prefs

note to anyone else: this is ready for review, I'll put it up once I'm not technically on vacation

[ Permalink | « Hide ]

Ian McEwen added a comment - 08/Jul/12 11:37 PM

http://codereview.musicbrainz.org/r/2032/

Ian McEwen made changes - 08/Jul/12 11:37 PM

Status

In Progress [ 3 ]

Review Submitted [ 5 ]

Oliver Charles made changes - 09/Jul/12 10:48 AM

Fix Version/s

Bug fixes, 2012-07-24 [ 10148 ]

Oliver Charles made changes - 09/Jul/12 12:54 PM

Status

Review Submitted [ 5 ]

In Beta Testing [ 10002 ]

[ Permalink | « Hide ]

Oliver Charles added a comment - 09/Jul/12 12:54 PM

ianmcorvidae/mbs-4793-datetime-prefs merged into beta.

Oliver Charles made changes - 23/Jul/12 05:24 AM

Status	In Beta Testing [ 10002 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]