Issue Details (XML | Word | Printable)

Key: MBS-4747
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: Nicolás Tamargo
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Wrong diff or wrong edit allowed for an URL

Created: 20/May/12 11:23 AM   Updated: 10/Sep/12 08:12 PM   Resolved: 10/Sep/12 08:12 PM
Component/s: None
Affects Version/s: None
Fix Version/s: Schema change, 2012-10-15

Issue Links:
Resolution
 


 Description  « Hide

In http://musicbrainz.org/edit/17685215 I changed the URL to one that seemed the same, but apparently was not (since it was on nikki's list of redirects). The edit was entered, and it usually isn't if there are no changes, so I suspect the problem is that it was some whitespace issue and the diff is not working for those. It can also be that it allowed an edit changing nothing to go through though.



Sort Order: Ascending order - Click to sort in descending order
Ian McEwen added a comment - 01/Sep/12 09:40 AM

I don't know if it's relevant, but the change data for that shows:

{"entity":{"name":"http://en.wikipedia.org/wiki/Born_and_Raised_(Cormega_album)","id":733573},"new":{"description":null},"old":{"description":""}}

So it looks like the description got changed null -> "" in any case. Do you remember what the original vs. changed URL was for that edit?


Ian McEwen added a comment - 01/Sep/12 09:53 AM

nikki's reproduced this with http://beta.musicbrainz.org/edit/18890163 – evidently there was no actual change to the URL, it's just the description changing from "" to null... whatever that means.


Ian McEwen added a comment - 01/Sep/12 01:11 PM

I think the fix for this may simply be:

UPDATE url SET description = NULL WHERE description = '';

or so.


Ian McEwen added a comment - 01/Sep/12 01:12 PM

Except not all at once, of course, given there's currently ~800k URLs with a description that's the empty string (and about 540k with it set to null).


Ian McEwen added a comment - 04/Sep/12 10:29 PM

Setting this to the schema change, since we've decided that's the appropriate time to run huge changes like this.


Ian McEwen added a comment - 06/Sep/12 07:07 PM

Dropping URL descriptions entirely would fix this nicely


Robert Kaye added a comment - 10/Sep/12 08:12 PM

This will be fixed by MBS-3791