Issue Details (XML | Word | Printable)

Key: MBS-4733
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Kuno Woudt
Reporter: tele
Votes: 3
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Merging release groups fails if release groups have secondary types

Created: 16/May/12 11:21 PM   Updated: 22/May/12 06:55 AM   Resolved: 22/May/12 06:55 AM
Component/s: None
Affects Version/s: Schema change, 2012-05-15
Fix Version/s: Bug fixes, 2012-05-28


 Description  « Hide

Presently 3 hours (cycles) have passed and 'some' Release Group mergers still have not closed.

Did not close http://musicbrainz.org/edit/17635722
Did close on same run - http://musicbrainz.org/edit/17634887

31 not closed - http://goo.gl/iwV7x



tele made changes - 16/May/12 11:24 PM
Field Original Value New Value
Priority Normal [ 6 ] Major [ 3 ]
Oliver Charles added a comment - 17/May/12 09:22 AM

Updated summary to reflect the actual problem. Here's a stack trace:

Edit queue processing starting
Failed query:
       '
       DELETE FROM release_group
       WHERE id IN (?)
       RETURNING gid'
       (583095)
DBD::Pg::st execute failed: ERROR:  update or delete on table "release_group" violates foreign key constraint "release_group_secondary_type_join_fk_release_group" on table "release_group_secondary_type_join"
DETAIL:  Key (id)=(583095) is still referenced from table "release_group_secondary_type_join". at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 409.

 at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 421
       Sql::__ANON__('DBD::Pg::st execute failed: ERROR:  update or delete on table...') called at local/lib/perl5/Try/Tiny.pm line 100
       Try::Tiny::try('CODE(0x8aba020)', 'Try::Tiny::Catch=REF(0x8ad0670)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 424
       Sql::_select_list('Sql=HASH(0x1cd8c10)', '\x{a}        DELETE FROM release_group\x{a}        WHERE id IN (?)\x{a}  ...', 'ARRAY(0x84ac948)', 'arrayref', 'CODE(0x1e9d708)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 443
       Sql::select_list_of_lists('Sql=HASH(0x1cd8c10)', '\x{a}        DELETE FROM release_group\x{a}        WHERE id IN (?)\x{a}  ...', 583095) called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 377
       Sql::select_single_column_array('Sql=HASH(0x1cd8c10)', '\x{a}        DELETE FROM release_group\x{a}        WHERE id IN (?)\x{a}  ...', 583095) called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/CoreEntity.pm line 159
       MusicBrainz::Server::Data::CoreEntity::_delete_and_redirect_gids('MusicBrainz::Server::Data::ReleaseGroup=HASH(0x865b978)', 'release_group', 583093, 583095) called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/ReleaseGroup.pm line 559
       MusicBrainz::Server::Data::ReleaseGroup::_merge_impl('MusicBrainz::Server::Data::ReleaseGroup=HASH(0x865b978)', 583093, 583095) called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Role/Merge.pm line 30
       Class::MOP::Class:::around('CODE(0x29422f8)', 'MusicBrainz::Server::Data::ReleaseGroup=HASH(0x865b978)', 583093, 583095) called at local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
       Class::MOP::Method::Wrapped::__ANON__('MusicBrainz::Server::Data::ReleaseGroup=HASH(0x865b978)', 583093, 583095) called at local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 91
       MusicBrainz::Server::Data::ReleaseGroup::merge('MusicBrainz::Server::Data::ReleaseGroup=HASH(0x865b978)', 583093, 583095) called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Edit/Generic/Merge.pm line 120
       MusicBrainz::Server::Edit::Generic::Merge::do_merge('MusicBrainz::Server::Edit::ReleaseGroup::Merge=HASH(0x7d975f8)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Edit/Generic/Merge.pm line 113
       MusicBrainz::Server::Edit::Generic::Merge::accept('MusicBrainz::Server::Edit::ReleaseGroup::Merge=HASH(0x7d975f8)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Edit.pm line 517
       MusicBrainz::Server::Data::Edit::__ANON__() called at local/lib/perl5/Try/Tiny.pm line 71
       eval {...} called at local/lib/perl5/Try/Tiny.pm line 67
       Try::Tiny::try('CODE(0x27b5408)', 'Try::Tiny::Catch=REF(0x8ab1750)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Edit.pm line 543
       MusicBrainz::Server::Data::Edit::_do_accept('MusicBrainz::Server::Data::Edit=HASH(0x7f49c20e6500)', 'MusicBrainz::Server::Edit::ReleaseGroup::Merge=HASH(0x7d975f8)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Edit.pm line 582
       MusicBrainz::Server::Data::Edit::__ANON__('MusicBrainz::Server::Edit::ReleaseGroup::Merge=HASH(0x7d975f8)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Edit.pm line 609
       MusicBrainz::Server::Data::Edit::_close('MusicBrainz::Server::Data::Edit=HASH(0x7f49c20e6500)', 'MusicBrainz::Server::Edit::ReleaseGroup::Merge=HASH(0x7d975f8)', 'CODE(0x8ad0640)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Edit.pm line 582
       MusicBrainz::Server::Data::Edit::accept('MusicBrainz::Server::Data::Edit=HASH(0x7f49c20e6500)', 'MusicBrainz::Server::Edit::ReleaseGroup::Merge=HASH(0x7d975f8)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/EditQueue.pm line 149
       MusicBrainz::Server::EditQueue::_process_open_edit('MusicBrainz::Server::EditQueue=HASH(0x1cd73e8)', 'MusicBrainz::Server::Edit::ReleaseGroup::Merge=HASH(0x7d975f8)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/EditQueue.pm line 111
       MusicBrainz::Server::EditQueue::_process_edit('MusicBrainz::Server::EditQueue=HASH(0x1cd73e8)', 17476295) called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/EditQueue.pm line 68
       MusicBrainz::Server::EditQueue::__ANON__() called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 277
       Sql::__ANON__() called at local/lib/perl5/Try/Tiny.pm line 76
       eval {...} called at local/lib/perl5/Try/Tiny.pm line 67
       Try::Tiny::try('CODE(0x865b600)', 'Try::Tiny::Catch=REF(0x84c57d0)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 290
       Sql::_auto_transaction('CODE(0x1e95048)', 'Sql=HASH(0x1cd8c10)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 295
       Sql::_run_in_transaction_one('CODE(0x1e95048)', 'Sql=HASH(0x1cd8c10)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 309
       Sql::run_in_transaction('CODE(0x1e95048)', 'Sql=HASH(0x1cd8c10)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/EditQueue.pm line 69
       MusicBrainz::Server::EditQueue::__ANON__() called at local/lib/perl5/Try/Tiny.pm line 76
       eval {...} called at local/lib/perl5/Try/Tiny.pm line 67
       Try::Tiny::try('CODE(0x1cf6778)', 'Try::Tiny::Catch=REF(0x804e140)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/EditQueue.pm line 77
       MusicBrainz::Server::EditQueue::process_edits('MusicBrainz::Server::EditQueue=HASH(0x1cd73e8)') called at ./admin/CheckVotes.pl line 56

Oliver Charles made changes - 17/May/12 09:22 AM
Summary Modbot quit merging 'some' Release Groups Merging release groups fails if release groups have secondary types
Issue Type Action Item [ 6 ] Bug [ 1 ]
Oliver Charles made changes - 17/May/12 09:30 AM
Fix Version/s Bug fixes, 2012-05-28 [ 10133 ]
Kuno Woudt made changes - 17/May/12 09:31 AM
Assignee Kuno Woudt [ warp ]
Kuno Woudt made changes - 17/May/12 11:18 AM
Status Open [ 1 ] Review Submitted [ 5 ]
Kuno Woudt added a comment - 22/May/12 06:55 AM

commit fbccab5565d9a070c7fc6f3d5d7bb45d24ae4481


Kuno Woudt made changes - 22/May/12 06:55 AM
Status Review Submitted [ 5 ] Closed [ 6 ]
Resolution Fixed [ 1 ]