Issue Details (XML | Word | Printable)

Key: MBS-4681
Type: Bug Bug
Status: Closed Closed
Resolution: Cannot Reproduce
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: Staffan Vilcans
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Edit maked as Applied, but it isn't

Created: 08/May/12 09:00 PM   Updated: 13/Aug/12 11:20 AM   Resolved: 13/Aug/12 11:20 AM
Component/s: Edit system
Affects Version/s: None
Fix Version/s: None

Issue Links:
Duplicate
 


 Description  « Hide

I have seen this in a few edits, for instance http://musicbrainz.org/edit/17396419 where it is marked as "This edit has been successfully applied." but in reality no change has been done.



Sort Order: Ascending order - Click to sort in descending order
Oliver Charles added a comment - 11/May/12 06:10 PM

Look into http://tickets.musicbrainz.org/browse/MBS-4681, and see why there is a name:null in the edit data. This should never be possible, and I have a feeling it's the edit hash -> JSON serialization part that has broken.


Kuno Woudt added a comment - 23/May/12 06:18 AM

Possibly the same issue in edit 17592810.


Kuno Woudt added a comment - 23/May/12 07:32 AM

Edit #17592810 can be recreated with these steps:

1. http://localhost:5000/artist/661d5c60-5213-4c0b-8314-21fc312692db/credit/864016/edit
2. open artist credit box
3. clear the credited name for the second artist
4. clear the artist name for the second artist, and click outside the input field
(the second artist now still has artist id 1 (various artists), but no name and no artist credit)
5. close the artist credit box and submit the edit


Kuno Woudt added a comment - 28/May/12 10:26 AM

commit f0f21b144df27b7288ea6983275162f247cd3a99


Staffan Vilcans added a comment - 14/Jun/12 03:02 PM

Judging from http://musicbrainz.org/edit/17819330 the problem still is there. It says "Status: Applied" but if you look at http://musicbrainz.org/release/90ae08e0-dba1-4d33-8b92-ba824e7881f4 that is not the case.


Kuno Woudt added a comment - 28/Jun/12 12:41 PM

Oliver, I'm assigning this to you.

I've attempted to reproduce this issue in the Edit::Medium::Test test (pushed as branch "mbs-4681"), but for me the edit always applies correctly. However, I don't want to just close as "Cannot Reproduce", in theory we have all the data to reproduce what happened. Perhaps you can have a look.


Oliver Charles added a comment - 13/Aug/12 11:20 AM

I also am unable to reproduce this or determine why it happens. If anyone does encounter this problem again, please report it as soon as you can and refrain from making more changes. There's some state that's causing this to break, but I don't know what it is.