Issue Details (XML | Word | Printable)

Key: MBS-4670
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: patate12
Reporter: patate12
Votes: 1
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

"Relate to..." maybe should not add #relate_to hash to address bar URL

Created: 07/May/12 03:12 PM   Updated: 01/Oct/12 01:25 PM   Resolved: 01/Oct/12 01:25 PM
Component/s: JavaScript, Templates, User interface
Affects Version/s: None
Fix Version/s: 2012-10-01


 Description  « Hide

If there is a reason to add #relate_to hash to address bar URL when clicking "Relate to..." sidebar tool link, tell me.
Otherwise, it would be nice not to add this so as to keep URL clean for later use.

FIX:

replace

<a href="#relate_to">Relate to ...</a>
by
<a style="cursor: pointer">Relate to ...</a>



Sort Order: Ascending order - Click to sort in descending order
patate12 added a comment - 03/Aug/12 09:39 AM

I suggest the FIX

<a style="cursor: pointer">


patate12 added a comment - 24/Aug/12 09:42 AM

patate12 added a comment - 29/Aug/12 06:24 PM

Sorry but why Won't Fix this inconvenience easy to solve ?


Oliver Charles added a comment - 30/Aug/12 09:23 AM

There is no bug and it is not worth anyone's time.


patate12 added a comment - 30/Aug/12 11:42 AM

« There is no bug »
Maybe I should have explained the inconveniences :

  • It prevents from fast reloading page (address bar, press enter reloads only document and uses cache for all resources).
  • It's irritating to find it pasted around instead of the clean URL

« it is not worth anyone's time. »
I can do it, it's worth mine.
The fix is only simple enough for my limited brain power :

<a style="cursor: pointer">Relate to ...</a>


Nicolás Tamargo added a comment - 30/Aug/12 11:45 AM

I agree this is annoying and just looks ugly.


Calvin Walton added a comment - 30/Aug/12 11:50 AM

The correct fix to this bug is fairly trivial. The Javascript code that opens the pop-up search dialog should return false to cancel navigation. It currently returns true, allowing the browser to navigate to the (non-existant) #relate-to anchor.


Calvin Walton added a comment - 30/Aug/12 11:51 AM

I'm going to take a look at doing the JS modification for this change in the next couple days, it's been really annoying me.


Aurélien Mino added a comment - 30/Aug/12 11:55 AM

+1 for fixing this too.
It has been annoying me for a long time: some userscripts were not running anymore because the URL had changed and was not matching anymore against userscript running URLs.


Calvin Walton added a comment - 30/Aug/12 12:25 PM

The issue that I was seeing was that clicking on the button navigated the page, and actually triggered the userscripts twice on the same page - really a bug in the browser, but still


patate12 added a comment - 30/Aug/12 01:38 PM

Calvin, I already said it but the no-href style-cursor:pointer is nicer to every cases, reserving the use of this link to only the javascript events and never seeing such a #relate_to copied link anywhere (because of a middle click for instance in Opera that launches the HREF in background tab without triggering the click javascript event). If no href it eventually eliminates all the such problems (I can think of).
It definitively eliminates any bad href copy chances and is the shortest straighforwardest fix.
But anyway if another fix is preferred I guess it will still be better than current.
Thanks for the ticket support BTW.


Calvin Walton added a comment - 04/Sep/12 03:55 PM

In IRC chat, jesus2099 said that he'd like to work on this issue.


patate12 added a comment - 04/Sep/12 04:08 PM

Thanks Calvin, I want to train myself on some unimportant stuff.
In IRC, Kuno suggested to use a button while not changing the way it is currently displayed (like a link).
As this relate to has a button behaviour rather than a link's.
I agree.


patate12 added a comment - 08/Sep/12 10:39 AM - edited

Decision Required
Hi guys this is my first try so please be indulgent.

Do I make the link to button as link solution instead?
There will be more CSS and more JS to insert in MBS.
cf. http://codereview.musicbrainz.org/r/2272/


Kuno Woudt added a comment - 08/Sep/12 11:06 AM

I did some experimenting earlier this week. It's almost impossible to make a <button> look like a <a> link (consistently in all browsers). So leaving it as <a> is ok.